about summary refs log tree commit diff
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2018-09-24 20:07:44 +0000
committerbors <bors@rust-lang.org>2018-09-24 20:07:44 +0000
commit5c875d93855c6d577962b0f74f17374f37b219c9 (patch)
treea97a542ff5a8394423839343df391c29a394720a
parent70073ec61d0d56bca45b9bd40659bb75799cd273 (diff)
parent1e3c86e1c40e703f632087751d073b58bd96a6df (diff)
downloadrust-5c875d93855c6d577962b0f74f17374f37b219c9.tar.gz
rust-5c875d93855c6d577962b0f74f17374f37b219c9.zip
Auto merge of #54416 - christianpoveda:master, r=wesleywiser
Extend MIR inlining to all operand variants

This fixes https://github.com/rust-lang/rust/issues/54193
r? @eddyb
-rw-r--r--src/librustc_mir/transform/inline.rs4
-rw-r--r--src/test/mir-opt/inline-any-operand.rs39
2 files changed, 41 insertions, 2 deletions
diff --git a/src/librustc_mir/transform/inline.rs b/src/librustc_mir/transform/inline.rs
index 8689fde3ee6..04f61235ca1 100644
--- a/src/librustc_mir/transform/inline.rs
+++ b/src/librustc_mir/transform/inline.rs
@@ -94,8 +94,8 @@ impl<'a, 'tcx> Inliner<'a, 'tcx> {
                 // Only consider direct calls to functions
                 let terminator = bb_data.terminator();
                 if let TerminatorKind::Call {
-                    func: Operand::Constant(ref f), .. } = terminator.kind {
-                        if let ty::FnDef(callee_def_id, substs) = f.ty.sty {
+                    func: ref op, .. } = terminator.kind {
+                        if let ty::FnDef(callee_def_id, substs) = op.ty(caller_mir, self.tcx).sty {
                             if let Some(instance) = Instance::resolve(self.tcx,
                                                                       param_env,
                                                                       callee_def_id,
diff --git a/src/test/mir-opt/inline-any-operand.rs b/src/test/mir-opt/inline-any-operand.rs
new file mode 100644
index 00000000000..da95842ea4d
--- /dev/null
+++ b/src/test/mir-opt/inline-any-operand.rs
@@ -0,0 +1,39 @@
+// Copyright 2017 The Rust Project Developers. See the COPYRIGHT
+// file at the top-level directory of this distribution and at
+// http://rust-lang.org/COPYRIGHT.
+//
+// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
+// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
+// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
+// option. This file may not be copied, modified, or distributed
+// except according to those terms.
+
+// compile-flags: -Z span_free_formats
+
+// Tests that MIR inliner works for any operand
+
+fn main() {
+    println!("{}", bar());
+}
+
+#[inline(always)]
+fn foo(x: i32, y: i32) -> bool {
+    x == y
+}
+
+fn bar() -> bool {
+    let f = foo;
+    f(1, -1)
+}
+
+// END RUST SOURCE
+// START rustc.bar.Inline.after.mir
+// ...
+// bb0: {
+//     ...
+//     _0 = Eq(move _3, move _4);
+//     ...
+//     return;
+// }
+// ...
+// END rustc.bar.Inline.after.mir