about summary refs log tree commit diff
diff options
context:
space:
mode:
authorbjorn3 <bjorn3@users.noreply.github.com>2021-05-03 18:38:52 +0200
committerbjorn3 <bjorn3@users.noreply.github.com>2021-05-03 18:42:00 +0200
commit5db01aae99a82675565c333ece511daa31d545cb (patch)
treec4a257e0d6fef3de7b19e1a05f19ab47329203b8
parent2fa18b8864be68948fdd5df2170bf75e5bb0b158 (diff)
downloadrust-5db01aae99a82675565c333ece511daa31d545cb.tar.gz
rust-5db01aae99a82675565c333ece511daa31d545cb.zip
Take build dependencies into account during license checks
The comment says that build dependencies shouldn't matter unless they do
some kind of codegen. It is safer to always check it though.
-rw-r--r--src/tools/tidy/src/deps.rs11
1 files changed, 1 insertions, 10 deletions
diff --git a/src/tools/tidy/src/deps.rs b/src/tools/tidy/src/deps.rs
index 86231946bb7..91008fc9fb7 100644
--- a/src/tools/tidy/src/deps.rs
+++ b/src/tools/tidy/src/deps.rs
@@ -460,16 +460,7 @@ fn normal_deps_of_r<'a>(
         .iter()
         .find(|n| &n.id == pkg_id)
         .unwrap_or_else(|| panic!("could not find `{}` in resolve", pkg_id));
-    // Don't care about dev-dependencies.
-    // Build dependencies *shouldn't* matter unless they do some kind of
-    // codegen. For now we'll assume they don't.
-    let deps = node.deps.iter().filter(|node_dep| {
-        node_dep
-            .dep_kinds
-            .iter()
-            .any(|kind_info| kind_info.kind == cargo_metadata::DependencyKind::Normal)
-    });
-    for dep in deps {
+    for dep in &node.deps {
         normal_deps_of_r(resolve, &dep.pkg, result);
     }
 }