diff options
| author | Matthias Krüger <matthias.krueger@famsik.de> | 2024-10-26 18:45:34 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-10-26 18:45:34 +0200 |
| commit | 5dd60103fa1f20a91c2a9ae839ae6b2f9083384c (patch) | |
| tree | cefa07c37009ad367d7dbf5bde491c1efff754d3 | |
| parent | 1f6cb859ee79b3f32eca5c87af87e9bc0aa4daa3 (diff) | |
| parent | 5f4739157abe8ac9ba3bbc652f6d7893d2a4d4c9 (diff) | |
| download | rust-5dd60103fa1f20a91c2a9ae839ae6b2f9083384c.tar.gz rust-5dd60103fa1f20a91c2a9ae839ae6b2f9083384c.zip | |
Rollup merge of #132182 - jieyouxu:downgrade-untranslatable, r=compiler-errors
Downgrade `untranslatable_diagnostic` and `diagnostic_outside_of_impl` to `allow` Current implementation of translatable diagnostics infrastructure unfortunately causes some friction for compiler contributors. While we don't have a redesign that causes less friction in place, let's downgrade the internal `untranslatable_diagnostic` and `diagnostic_outside_of_impl` lints so we don't indicate to contributors that they *have* to use the current translation infra. I purposefully left `#[allow(untranslatable_diagnostic)]` and `#[allow(diagnostic_outside_of_impl)]` instances untouched because that seems like unnecessary additional churn. See <https://github.com/rust-lang/rust/issues/132181> for context. r? `@davidtwco` (or wg-diagnostics/compiler)
| -rw-r--r-- | compiler/rustc_lint/src/internal.rs | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/compiler/rustc_lint/src/internal.rs b/compiler/rustc_lint/src/internal.rs index 94cc58e4956..71f6214d880 100644 --- a/compiler/rustc_lint/src/internal.rs +++ b/compiler/rustc_lint/src/internal.rs @@ -427,7 +427,7 @@ declare_tool_lint! { /// More details on translatable diagnostics can be found /// [here](https://rustc-dev-guide.rust-lang.org/diagnostics/translation.html). pub rustc::UNTRANSLATABLE_DIAGNOSTIC, - Deny, + Allow, "prevent creation of diagnostics which cannot be translated", report_in_external_macro: true } @@ -440,7 +440,7 @@ declare_tool_lint! { /// More details on diagnostics implementations can be found /// [here](https://rustc-dev-guide.rust-lang.org/diagnostics/diagnostic-structs.html). pub rustc::DIAGNOSTIC_OUTSIDE_OF_IMPL, - Deny, + Allow, "prevent diagnostic creation outside of `Diagnostic`/`Subdiagnostic`/`LintDiagnostic` impls", report_in_external_macro: true } |