diff options
| author | Felix S Klock II <pnkfelix@pnkfx.org> | 2019-10-03 11:08:28 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-10-03 11:08:28 +0200 |
| commit | 5e7e8cd41f5591285bf764e3a8fc87ed89db21ba (patch) | |
| tree | 5a4bfc7b76ec485d113250a0ce3096989679be44 | |
| parent | e7e6dec06a050c5bc4e7a93e6700fad28570779a (diff) | |
| download | rust-5e7e8cd41f5591285bf764e3a8fc87ed89db21ba.tar.gz rust-5e7e8cd41f5591285bf764e3a8fc87ed89db21ba.zip | |
Update attributes.rs
Some comment refinements inspired by review feedback.
| -rw-r--r-- | src/librustc_codegen_llvm/attributes.rs | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/src/librustc_codegen_llvm/attributes.rs b/src/librustc_codegen_llvm/attributes.rs index 73d43289d19..423a2df3523 100644 --- a/src/librustc_codegen_llvm/attributes.rs +++ b/src/librustc_codegen_llvm/attributes.rs @@ -281,7 +281,7 @@ pub fn from_fn_attrs( // // However, in the long term we should either: // - fold this into final else (i.e. stop inspecting `id`) - // - adopt Rust PR #63909. + // - or, adopt Rust PR #63909. // // see also Rust RFC 2753. @@ -302,9 +302,10 @@ pub fn from_fn_attrs( // UB otherwise. (At least for now; see also // rust-lang/rust#63909 and Rust RFC 2753.) // - // Items defined in Rust with non-Rust ABIs (case 2) are - // defined to not unwind. We insert shims to abort if an - // unwind happens to enforce this. + // Items defined in Rust with non-Rust ABIs (case 2) are also + // not supposed to unwind. Whether this should be enforced + // (versus stating it is UB) and *how* it would be enforced + // is currently under discussion; see rust-lang/rust#58794. // // In either case, we mark item as explicitly nounwind. false |