about summary refs log tree commit diff
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2024-09-27 05:14:35 +0000
committerbors <bors@rust-lang.org>2024-09-27 05:14:35 +0000
commit5fcfd95dbf7ad63b9c3ddd9f45590616a891bce8 (patch)
tree270c26aef49e1a28067a8d70ed4edcc515537111
parenta547baed6230d5f505ee4dc8ba03d1ca3cb12088 (diff)
parent99de8516f983b5fbaedb89320b1d08744f802050 (diff)
downloadrust-5fcfd95dbf7ad63b9c3ddd9f45590616a891bce8.tar.gz
rust-5fcfd95dbf7ad63b9c3ddd9f45590616a891bce8.zip
Auto merge of #18197 - alibektas:buggy_flycheck_message, r=Veykril
minor: Stricter requirements for package wide flycheck

Require the existence of a target and `check_workspace` to be false to restart package-wide flycheck. Fixes #18194 , #18104
-rw-r--r--src/tools/rust-analyzer/crates/rust-analyzer/src/handlers/notification.rs2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/tools/rust-analyzer/crates/rust-analyzer/src/handlers/notification.rs b/src/tools/rust-analyzer/crates/rust-analyzer/src/handlers/notification.rs
index 49b1ba32a79..bb03eb3c89b 100644
--- a/src/tools/rust-analyzer/crates/rust-analyzer/src/handlers/notification.rs
+++ b/src/tools/rust-analyzer/crates/rust-analyzer/src/handlers/notification.rs
@@ -380,7 +380,7 @@ fn run_flycheck(state: &mut GlobalState, vfs_path: VfsPath) -> bool {
                     if id == flycheck.id() {
                         updated = true;
                         match package.filter(|_| {
-                            !world.config.flycheck_workspace(source_root_id) || target.is_some()
+                            !world.config.flycheck_workspace(source_root_id) && target.is_some()
                         }) {
                             Some(package) => flycheck
                                 .restart_for_package(package, target.clone().map(TupleExt::head)),