about summary refs log tree commit diff
diff options
context:
space:
mode:
authorKelsey Gilbert <jdashg@gmail.com>2022-05-10 16:15:48 -0700
committerKelsey Gilbert <jdashg@gmail.com>2022-05-12 16:34:02 -0700
commit5fde765df08d5f9d22df1368a8dbc0ed99e52b04 (patch)
tree98719d5624a32d850c41573a4a605a171bb352ed
parent88860d5474a32f507dde8fba8df35fd2064f11b9 (diff)
downloadrust-5fde765df08d5f9d22df1368a8dbc0ed99e52b04.tar.gz
rust-5fde765df08d5f9d22df1368a8dbc0ed99e52b04.zip
[save-analysis] Reference the variant not enum at struct-literal construction.
Closes #96985
-rw-r--r--compiler/rustc_save_analysis/src/dump_visitor.rs11
1 files changed, 8 insertions, 3 deletions
diff --git a/compiler/rustc_save_analysis/src/dump_visitor.rs b/compiler/rustc_save_analysis/src/dump_visitor.rs
index e1c9ecc055f..fe417f45e88 100644
--- a/compiler/rustc_save_analysis/src/dump_visitor.rs
+++ b/compiler/rustc_save_analysis/src/dump_visitor.rs
@@ -780,13 +780,18 @@ impl<'tcx> DumpVisitor<'tcx> {
         variant: &'tcx ty::VariantDef,
         rest: Option<&'tcx hir::Expr<'tcx>>,
     ) {
-        if let Some(struct_lit_data) = self.save_ctxt.get_expr_data(ex) {
+        if let Some(_ex_res_data) = self.save_ctxt.get_expr_data(ex) {
             if let hir::QPath::Resolved(_, path) = path {
                 self.write_sub_paths_truncated(path);
             }
-            down_cast_data!(struct_lit_data, RefData, ex.span);
+            // For MyEnum::MyVariant, get_expr_data gives us MyEnum, not MyVariant.
+            // For recording the span's ref id, we want MyVariant.
             if !generated_code(ex.span) {
-                self.dumper.dump_ref(struct_lit_data);
+                let sub_span = path.last_segment_span();
+                let span = self.save_ctxt.span_from_span(sub_span);
+                let reff =
+                    Ref { kind: RefKind::Type, span, ref_id: id_from_def_id(variant.def_id) };
+                self.dumper.dump_ref(reff);
             }
 
             for field in fields {