diff options
| author | Rajveer <rajveer.developer@icloud.com> | 2024-04-03 00:49:43 +0530 |
|---|---|---|
| committer | Rajveer <rajveer.developer@icloud.com> | 2024-04-03 17:17:40 +0530 |
| commit | 66dee4a9aa759748319f4e9c81dbb87d7e759ee0 (patch) | |
| tree | 541e8aa4d72d0d47031b2538a22f273c40f3ab3e | |
| parent | 36b6f9b58e78a1225a322a759e42c262e6dc8d5d (diff) | |
| download | rust-66dee4a9aa759748319f4e9c81dbb87d7e759ee0.tar.gz rust-66dee4a9aa759748319f4e9c81dbb87d7e759ee0.zip | |
Set `CARGO` instead of `PATH` for Rust Clippy
Resolves #123227
| -rw-r--r-- | src/bootstrap/src/core/builder.rs | 13 |
1 files changed, 2 insertions, 11 deletions
diff --git a/src/bootstrap/src/core/builder.rs b/src/bootstrap/src/core/builder.rs index c051b818328..0cce5130f64 100644 --- a/src/bootstrap/src/core/builder.rs +++ b/src/bootstrap/src/core/builder.rs @@ -1194,20 +1194,11 @@ impl<'a> Builder<'a> { } pub fn cargo_clippy_cmd(&self, run_compiler: Compiler) -> Command { - let initial_sysroot_bin = self.initial_rustc.parent().unwrap(); - // Set PATH to include the sysroot bin dir so clippy can find cargo. - // FIXME: once rust-clippy#11944 lands on beta, set `CARGO` directly instead. - let path = t!(env::join_paths( - // The sysroot comes first in PATH to avoid using rustup's cargo. - std::iter::once(PathBuf::from(initial_sysroot_bin)) - .chain(env::split_paths(&t!(env::var("PATH")))) - )); - if run_compiler.stage == 0 { // `ensure(Clippy { stage: 0 })` *builds* clippy with stage0, it doesn't use the beta clippy. let cargo_clippy = self.build.config.download_clippy(); let mut cmd = Command::new(cargo_clippy); - cmd.env("PATH", &path); + cmd.env("CARGO", &self.initial_cargo); return cmd; } @@ -1227,7 +1218,7 @@ impl<'a> Builder<'a> { let mut cmd = Command::new(cargo_clippy); cmd.env(helpers::dylib_path_var(), env::join_paths(&dylib_path).unwrap()); - cmd.env("PATH", path); + cmd.env("CARGO", &self.initial_cargo); cmd } |
