diff options
| author | Jubilee <46493976+workingjubilee@users.noreply.github.com> | 2024-06-06 14:46:22 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-06-06 14:46:22 -0700 |
| commit | 68c57de26e4ac6a9b8f3c45ddb40e3a717cfcc81 (patch) | |
| tree | 244f9df850575f759a33d5567e88e9c63b6ad2b8 | |
| parent | f739fefc76b7928827e1e0875cd5f09460a78a1e (diff) | |
| parent | 878107436a2c4ca60f1e87246fdb3480e1f2058b (diff) | |
| download | rust-68c57de26e4ac6a9b8f3c45ddb40e3a717cfcc81.tar.gz rust-68c57de26e4ac6a9b8f3c45ddb40e3a717cfcc81.zip | |
Rollup merge of #126059 - workingjubilee:stack-nothing-higher, r=ChrisDenton
Raise `DEFAULT_MIN_STACK_SIZE` to at least 64KiB Prevent copy-paste errors from producing new starved-for-resources threaded platforms by raising `DEFAULT_MIN_STACK_SIZE` from 4096 bytes to at least 64KiB. Two platforms "affected" by this have no actual threads: - UEFI - "unsupported" Platforms that this actually affects: - wasm32-wasi with "atomics" enabled - wasm32-wasi-p1-threads Two exceptions: - SGX: a "secure code execution" platform, stays at 4096B - TEEOS: also a "secure code execution" platform, stays at 8192B I believe either of these may have sufficiently "interesting" semantics around threads, or significant external library support. Either would mean making any choices here for them is suspect. Fixes #126027 which is a bug report about `DEFAULT_MIN_STACK_SIZE` being too low on wasi.
| -rw-r--r-- | library/std/src/sys/pal/uefi/thread.rs | 2 | ||||
| -rw-r--r-- | library/std/src/sys/pal/unsupported/thread.rs | 2 | ||||
| -rw-r--r-- | library/std/src/sys/pal/wasi/thread.rs | 2 | ||||
| -rw-r--r-- | library/std/src/sys/pal/wasm/atomics/thread.rs | 2 |
4 files changed, 4 insertions, 4 deletions
diff --git a/library/std/src/sys/pal/uefi/thread.rs b/library/std/src/sys/pal/uefi/thread.rs index edc736978a1..7d4006ff4b2 100644 --- a/library/std/src/sys/pal/uefi/thread.rs +++ b/library/std/src/sys/pal/uefi/thread.rs @@ -7,7 +7,7 @@ use crate::time::Duration; pub struct Thread(!); -pub const DEFAULT_MIN_STACK_SIZE: usize = 4096; +pub const DEFAULT_MIN_STACK_SIZE: usize = 64 * 1024; impl Thread { // unsafe: see thread::Builder::spawn_unchecked for safety requirements diff --git a/library/std/src/sys/pal/unsupported/thread.rs b/library/std/src/sys/pal/unsupported/thread.rs index ea939247199..89f8bad7026 100644 --- a/library/std/src/sys/pal/unsupported/thread.rs +++ b/library/std/src/sys/pal/unsupported/thread.rs @@ -6,7 +6,7 @@ use crate::time::Duration; pub struct Thread(!); -pub const DEFAULT_MIN_STACK_SIZE: usize = 4096; +pub const DEFAULT_MIN_STACK_SIZE: usize = 64 * 1024; impl Thread { // unsafe: see thread::Builder::spawn_unchecked for safety requirements diff --git a/library/std/src/sys/pal/wasi/thread.rs b/library/std/src/sys/pal/wasi/thread.rs index d45fb28b67e..975eef2451f 100644 --- a/library/std/src/sys/pal/wasi/thread.rs +++ b/library/std/src/sys/pal/wasi/thread.rs @@ -66,7 +66,7 @@ cfg_if::cfg_if! { } } -pub const DEFAULT_MIN_STACK_SIZE: usize = 4096; +pub const DEFAULT_MIN_STACK_SIZE: usize = 64 * 1024; impl Thread { // unsafe: see thread::Builder::spawn_unchecked for safety requirements diff --git a/library/std/src/sys/pal/wasm/atomics/thread.rs b/library/std/src/sys/pal/wasm/atomics/thread.rs index 49f936f1449..484bd08495e 100644 --- a/library/std/src/sys/pal/wasm/atomics/thread.rs +++ b/library/std/src/sys/pal/wasm/atomics/thread.rs @@ -6,7 +6,7 @@ use crate::time::Duration; pub struct Thread(!); -pub const DEFAULT_MIN_STACK_SIZE: usize = 4096; +pub const DEFAULT_MIN_STACK_SIZE: usize = 64 * 1024; impl Thread { // unsafe: see thread::Builder::spawn_unchecked for safety requirements |