about summary refs log tree commit diff
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2015-12-01 21:38:20 +0000
committerbors <bors@rust-lang.org>2015-12-01 21:38:20 +0000
commit69b2fce7bb2283ceb950f786c15cbbcd50787c8e (patch)
tree10e1ddf7ac1235ce09438626fd5e837d117a4ed0
parenteb1d018c01f70bcfc38bc8365a3de71c1564f694 (diff)
parent9612c9ab2074ad8187b505d53682babc209a3ddd (diff)
downloadrust-69b2fce7bb2283ceb950f786c15cbbcd50787c8e.tar.gz
rust-69b2fce7bb2283ceb950f786c15cbbcd50787c8e.zip
Auto merge of #29858 - fhahn:abort-if-path-has-spaces, r=brson
The Rust build scripts do work if the source directory contains spaces. I tried to make it work with spaces. I managed to get the Rust's and LLVM's configure scripts to work with spaces in the path, but I could not figure out how to get the Rust makefiles working.

So for now, this PR updates Rust's `configure` to abort if the source path contains spaces. I also added a note about spaces in the source path to the README.

I think this should close #18477 for now.
-rwxr-xr-xconfigure10
1 files changed, 10 insertions, 0 deletions
diff --git a/configure b/configure
index 1c63f74db3b..c505af5c4d3 100755
--- a/configure
+++ b/configure
@@ -541,6 +541,16 @@ CFG_BUILD_DIR="$(pwd)/"
 CFG_SELF="$0"
 CFG_CONFIGURE_ARGS="$@"
 
+
+case "${CFG_SRC_DIR}" in  
+    *\ * )
+        err "The path to the rust source directory contains spaces, which is not supported"
+        ;;
+    *)
+        ;;
+esac
+
+
 OPTIONS=""
 HELP=0
 if [ "$1" = "--help" ]