about summary refs log tree commit diff
diff options
context:
space:
mode:
authorDylan MacKenzie <ecstaticmorse@gmail.com>2021-12-05 13:11:55 -0800
committerDylan MacKenzie <ecstaticmorse@gmail.com>2021-12-05 13:11:55 -0800
commit6afbfcaa3ec1053d806af2055ded58b1faff4dee (patch)
treebf497736dfabd923986f54ce0af2367218b7b1a7
parent772d51f887fa407216860bf8ecf3f1a32fb795b4 (diff)
downloadrust-6afbfcaa3ec1053d806af2055ded58b1faff4dee.tar.gz
rust-6afbfcaa3ec1053d806af2055ded58b1faff4dee.zip
Remove unnecessary FIXME (answered by Oli)
-rw-r--r--compiler/rustc_mir_transform/src/lib.rs3
1 files changed, 1 insertions, 2 deletions
diff --git a/compiler/rustc_mir_transform/src/lib.rs b/compiler/rustc_mir_transform/src/lib.rs
index a7e003a55b4..130688e2d53 100644
--- a/compiler/rustc_mir_transform/src/lib.rs
+++ b/compiler/rustc_mir_transform/src/lib.rs
@@ -480,8 +480,7 @@ fn run_optimization_passes<'tcx>(tcx: TyCtxt<'tcx>, body: &mut Body<'tcx>) {
             // FIXME(#70073): This pass is responsible for both optimization as well as some lints.
             &const_prop::ConstProp,
             //
-            // FIXME: The old pass manager ran this only at mir-opt-level >= 1, but
-            // const-prop runs unconditionally. Should this run unconditionally as well?
+            // Const-prop runs unconditionally, but doesn't mutate the MIR at mir-opt-level=0.
             &o1(simplify_branches::SimplifyConstCondition::new("after-const-prop")),
             &early_otherwise_branch::EarlyOtherwiseBranch,
             &simplify_comparison_integral::SimplifyComparisonIntegral,