diff options
| author | Tim Chevalier <chevalier@alum.wellesley.edu> | 2012-06-14 18:46:33 -0700 |
|---|---|---|
| committer | Tim Chevalier <chevalier@alum.wellesley.edu> | 2012-06-14 18:46:33 -0700 |
| commit | 6b16325f43d1e7bbdc7ad55301c17c027f9a716d (patch) | |
| tree | 9cbc9ed89e71e09e6153730f597a0db52cbf81bc | |
| parent | dce5d6ab9c2098d83a5499f8ad33bc0a1a649762 (diff) | |
| download | rust-6b16325f43d1e7bbdc7ad55301c17c027f9a716d.tar.gz rust-6b16325f43d1e7bbdc7ad55301c17c027f9a716d.zip | |
Comments only: annotate FIXMEs
| -rw-r--r-- | src/libstd/par.rs | 2 | ||||
| -rw-r--r-- | src/libsyntax/ast_map.rs | 2 | ||||
| -rw-r--r-- | src/libsyntax/ast_util.rs | 2 | ||||
| -rw-r--r-- | src/libsyntax/attr.rs | 3 |
4 files changed, 6 insertions, 3 deletions
diff --git a/src/libstd/par.rs b/src/libstd/par.rs index d12a7e71a63..ffca5989857 100644 --- a/src/libstd/par.rs +++ b/src/libstd/par.rs @@ -39,7 +39,7 @@ fn map_slices<A: copy send, B: copy send>( log(info, "spawning tasks"); while base < len { let end = uint::min(len, base + items_per_task); - // FIXME: why is the ::<A, ()> annotation required here? + // FIXME: why is the ::<A, ()> annotation required here? (#2617) vec::unpack_slice::<A, ()>(xs) {|p, _len| let f = f(); futures += [future::spawn() {|copy base| diff --git a/src/libsyntax/ast_map.rs b/src/libsyntax/ast_map.rs index 98a3a8e7bcc..e11e673494c 100644 --- a/src/libsyntax/ast_map.rs +++ b/src/libsyntax/ast_map.rs @@ -9,6 +9,7 @@ import diagnostic::span_handler; enum path_elt { path_mod(ident), path_name(ident) } type path = [path_elt]; +/* FIXMEs that say "bad" are as per #2543 */ fn path_to_str_with_sep(p: path, sep: str) -> str { let strs = vec::map(p) {|e| alt e { @@ -291,6 +292,7 @@ fn node_id_to_str(map: map, id: node_id) -> str { #fmt["expr %s (id=%?)", pprust::expr_to_str(expr), id] } + // FIXMEs are as per #2410 some(node_export(_, path)) { #fmt["export %s (id=%?)", // FIXME: add more info here path_to_str(*path), id] diff --git a/src/libsyntax/ast_util.rs b/src/libsyntax/ast_util.rs index d4efdb4bb0d..ef3b0332f19 100644 --- a/src/libsyntax/ast_util.rs +++ b/src/libsyntax/ast_util.rs @@ -24,7 +24,7 @@ pure fn dummy_sp() -> span { ret mk_sp(0u, 0u); } pure fn path_name(p: @path) -> str { path_name_i(p.idents) } pure fn path_name_i(idents: [ident]) -> str { - // FIXME: Bad copies + // FIXME: Bad copies (#2543 -- same for everything else that says "bad") str::connect(idents.map({|i|*i}), "::") } diff --git a/src/libsyntax/attr.rs b/src/libsyntax/attr.rs index 9138fed69c8..5dfe40b7ee0 100644 --- a/src/libsyntax/attr.rs +++ b/src/libsyntax/attr.rs @@ -88,6 +88,7 @@ fn get_attr_name(attr: ast::attribute) -> ast::ident { get_meta_item_name(@attr.node.value) } +// All "bad" FIXME copies are as per #2543 fn get_meta_item_name(meta: @ast::meta_item) -> ast::ident { alt meta.node { ast::meta_word(n) { /* FIXME bad */ copy n } @@ -372,7 +373,7 @@ fn require_unique_names(diagnostic: span_handler, for metas.each {|meta| let name = get_meta_item_name(meta); - // FIXME: How do I silence the warnings? --pcw + // FIXME: How do I silence the warnings? --pcw (#2619) if map.contains_key(*name) { diagnostic.span_fatal(meta.span, #fmt["duplicate meta item `%s`", *name]); |
