about summary refs log tree commit diff
diff options
context:
space:
mode:
authorAnders Kaseorg <andersk@mit.edu>2015-03-23 04:02:02 -0400
committerAnders Kaseorg <andersk@mit.edu>2015-03-23 04:02:02 -0400
commit737bb30f0af5b27785a006a91a8792a06478de87 (patch)
tree5e7a3562a3439989920900b3694a8560a8709e42
parentb6641c1595687a6c7c8ba381b46b931a58a3ada4 (diff)
downloadrust-737bb30f0af5b27785a006a91a8792a06478de87.tar.gz
rust-737bb30f0af5b27785a006a91a8792a06478de87.zip
min_stack_size: clarify both reasons to use dlsym
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
-rw-r--r--src/libstd/sys/unix/thread.rs11
1 files changed, 6 insertions, 5 deletions
diff --git a/src/libstd/sys/unix/thread.rs b/src/libstd/sys/unix/thread.rs
index b3594dcaa75..c66d86b7625 100644
--- a/src/libstd/sys/unix/thread.rs
+++ b/src/libstd/sys/unix/thread.rs
@@ -316,11 +316,12 @@ pub fn sleep(dur: Duration) {
 // is created in an application with big thread-local storage requirements.
 // See #6233 for rationale and details.
 //
-// Use dlsym to get the symbol value at runtime, for compatibility
-// with older versions of glibc.  Assumes that we've been dynamically
-// linked to libpthread but that is currently always the case.  We
-// previously used weak linkage (under the same assumption), but that
-// caused Debian to detect an unnecessarily strict versioned
+// Use dlsym to get the symbol value at runtime, both for
+// compatibility with older versions of glibc, and to avoid creating
+// dependencies on GLIBC_PRIVATE symbols.  Assumes that we've been
+// dynamically linked to libpthread but that is currently always the
+// case.  We previously used weak linkage (under the same assumption),
+// but that caused Debian to detect an unnecessarily strict versioned
 // dependency on libc6 (#23628).
 #[cfg(target_os = "linux")]
 fn min_stack_size(attr: *const libc::pthread_attr_t) -> libc::size_t {