diff options
| author | Miguel Ojeda <ojeda@kernel.org> | 2022-01-28 00:54:55 +0100 |
|---|---|---|
| committer | Miguel Ojeda <ojeda@kernel.org> | 2022-01-28 13:34:14 +0100 |
| commit | 748cdda776c19593aaf5a3f51eb24179192607d2 (patch) | |
| tree | 3ce7df43e2a8225e1c10542c5c9796c550306c9b | |
| parent | 312a7995e73e390646bc61920ffead7a640addc6 (diff) | |
| download | rust-748cdda776c19593aaf5a3f51eb24179192607d2.tar.gz rust-748cdda776c19593aaf5a3f51eb24179192607d2.zip | |
rustdoc: no `shortcut` in `rel="icon"`
According to https://html.spec.whatwg.org/multipage/links.html#rel-icon:
> For historical reasons, the `icon` keyword may be preceded by
> the keyword "`shortcut`".
And to https://developer.mozilla.org/en-US/docs/Web/HTML/Link_types:
> **Warning:** The `shortcut` link type is often seen before `icon`,
> but this link type is non-conforming, ignored and **web authors
> must not use it anymore.**
While it was removed from the Rust logo case a while ago in commit
085679c8414 ("Use theme-adaptive SVG favicon from other Rust sites"),
it is still there for the custom logo case.
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
| -rw-r--r-- | src/doc/rustdoc/src/the-doc-attribute.md | 2 | ||||
| -rw-r--r-- | src/librustdoc/html/templates/page.html | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/doc/rustdoc/src/the-doc-attribute.md b/src/doc/rustdoc/src/the-doc-attribute.md index a75b6d38931..c5cc84022e3 100644 --- a/src/doc/rustdoc/src/the-doc-attribute.md +++ b/src/doc/rustdoc/src/the-doc-attribute.md @@ -59,7 +59,7 @@ This form of the `doc` attribute lets you control the favicon of your docs. #![doc(html_favicon_url = "https://example.com/favicon.ico")] ``` -This will put `<link rel="shortcut icon" href="{}">` into your docs, where +This will put `<link rel="icon" href="{}">` into your docs, where the string for the attribute goes into the `{}`. If you don't use this attribute, there will be no favicon. diff --git a/src/librustdoc/html/templates/page.html b/src/librustdoc/html/templates/page.html index baadd3c27b4..564731ab735 100644 --- a/src/librustdoc/html/templates/page.html +++ b/src/librustdoc/html/templates/page.html @@ -54,7 +54,7 @@ href="{{static_root_path|safe}}theme{{page.resource_suffix}}.css"> {#- -#} {%- endif -%} {%- if !layout.favicon.is_empty() -%} - <link rel="shortcut icon" href="{{layout.favicon}}"> {#- -#} + <link rel="icon" href="{{layout.favicon}}"> {#- -#} {%- else -%} <link rel="alternate icon" type="image/png" {# -#} href="{{static_root_path|safe}}favicon-16x16{{page.resource_suffix}}.png"> {#- -#} |