diff options
| author | Manish Goregaokar <manishsmail@gmail.com> | 2024-12-02 18:42:13 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-12-02 18:42:13 +0000 |
| commit | 74dd50c65387a3e71e9b83c2915712022e75ca12 (patch) | |
| tree | 72604f132f747356e6003f4c3c4c9c0c3ba061f3 | |
| parent | 2ddfc92ea2a0a9b63e7d90f38b141667378db49e (diff) | |
| parent | 2b0e7bb4a77cf1c41c1b6b787b75cc82135c6876 (diff) | |
| download | rust-74dd50c65387a3e71e9b83c2915712022e75ca12.tar.gz rust-74dd50c65387a3e71e9b83c2915712022e75ca12.zip | |
Fix lifetimes elision suggestion in where clauses (#13752)
Fix #13749 changelog: [`needless_lifetimes`]: do not suggest using `'_` in `where` clauses
| -rw-r--r-- | clippy_lints/src/lifetimes.rs | 6 | ||||
| -rw-r--r-- | tests/ui/needless_lifetimes.fixed | 14 | ||||
| -rw-r--r-- | tests/ui/needless_lifetimes.rs | 14 |
3 files changed, 28 insertions, 6 deletions
diff --git a/clippy_lints/src/lifetimes.rs b/clippy_lints/src/lifetimes.rs index 35b14776e59..ee2e1ee32bb 100644 --- a/clippy_lints/src/lifetimes.rs +++ b/clippy_lints/src/lifetimes.rs @@ -658,12 +658,6 @@ fn report_elidable_impl_lifetimes<'tcx>( lifetime, in_where_predicate: false, .. - } - | Usage { - lifetime, - in_bounded_ty: false, - in_generics_arg: false, - .. }, ] = usages.as_slice() { diff --git a/tests/ui/needless_lifetimes.fixed b/tests/ui/needless_lifetimes.fixed index cfa4cf9da3c..8196d608abd 100644 --- a/tests/ui/needless_lifetimes.fixed +++ b/tests/ui/needless_lifetimes.fixed @@ -562,4 +562,18 @@ mod rayon { } } +mod issue13749 { + pub struct Generic<T>(T); + // Non elidable lifetime + #[expect(clippy::extra_unused_lifetimes)] + impl<'a, T> Generic<T> where T: 'a {} +} + +mod issue13749bis { + pub struct Generic<T>(T); + // Non elidable lifetime + #[expect(clippy::extra_unused_lifetimes)] + impl<'a, T: 'a> Generic<T> {} +} + fn main() {} diff --git a/tests/ui/needless_lifetimes.rs b/tests/ui/needless_lifetimes.rs index 5e9d5116426..b55dd99c46d 100644 --- a/tests/ui/needless_lifetimes.rs +++ b/tests/ui/needless_lifetimes.rs @@ -562,4 +562,18 @@ mod rayon { } } +mod issue13749 { + pub struct Generic<T>(T); + // Non elidable lifetime + #[expect(clippy::extra_unused_lifetimes)] + impl<'a, T> Generic<T> where T: 'a {} +} + +mod issue13749bis { + pub struct Generic<T>(T); + // Non elidable lifetime + #[expect(clippy::extra_unused_lifetimes)] + impl<'a, T: 'a> Generic<T> {} +} + fn main() {} |
