about summary refs log tree commit diff
diff options
context:
space:
mode:
authorRicky <ricky@hosfelt.io>2020-12-03 17:44:50 -0500
committerGitHub <noreply@github.com>2020-12-03 17:44:50 -0500
commit75482f917d7fc65190274bd577dcc2e30ba34aff (patch)
tree1967ae0abd2060523348c25741a48dc1451d2382
parentf633ef6bba70b91f0415316fe10bb1f9c016ba33 (diff)
downloadrust-75482f917d7fc65190274bd577dcc2e30ba34aff.tar.gz
rust-75482f917d7fc65190274bd577dcc2e30ba34aff.zip
Apply suggestions from code review
updated help message for the user

Co-authored-by: Jane Lusby <jlusby42@gmail.com>
-rw-r--r--clippy_lints/src/map_err_ignore.rs4
1 files changed, 2 insertions, 2 deletions
diff --git a/clippy_lints/src/map_err_ignore.rs b/clippy_lints/src/map_err_ignore.rs
index 324a11f140a..f3c0515b9bc 100644
--- a/clippy_lints/src/map_err_ignore.rs
+++ b/clippy_lints/src/map_err_ignore.rs
@@ -133,9 +133,9 @@ impl<'tcx> LateLintPass<'tcx> for MapErrIgnore {
                                     cx,
                                     MAP_ERR_IGNORE,
                                     body_span,
-                                    "`map_err(|_|...` ignores the original error",
+                                    "`map_err(|_|...` wildcard pattern discards the original error",
                                     None,
-                                    "Consider wrapping the error in an enum variant for more error context, or using a named wildcard (`.map_err(|_ignored| ...`) to intentionally ignore the error",
+                                    "Consider storing the original error as a source in the new error, or silence this warning using an ignored identifier (`.map_err(|_foo| ...`)",
                                 );
                             }
                         }