about summary refs log tree commit diff
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2022-11-12 11:44:22 +0000
committerbors <bors@rust-lang.org>2022-11-12 11:44:22 +0000
commit755fe4dc24af549559fc9c32bc953eed7a3c86e4 (patch)
tree4515d65cb72f5f83d3ddb751bc85b9064321d8f8
parentcad0d3d6da87b6e34a973a6dd6b34cfedeab3ea6 (diff)
parent39398e163ac7508b585f07821e5be195102a4017 (diff)
downloadrust-755fe4dc24af549559fc9c32bc953eed7a3c86e4.tar.gz
rust-755fe4dc24af549559fc9c32bc953eed7a3c86e4.zip
Auto merge of #9834 - koka831:refac/manual-is-ascii-check, r=xFrednet
refac: remove unnecessary mutability

refactor `manual_is_ascii_check` lint.

* remove unnecessary mutability
* fix typo

changelog: none

r? `@xFrednet`
-rw-r--r--clippy_lints/src/manual_is_ascii_check.rs11
1 files changed, 6 insertions, 5 deletions
diff --git a/clippy_lints/src/manual_is_ascii_check.rs b/clippy_lints/src/manual_is_ascii_check.rs
index 3a6b693f766..bb8c142f8e4 100644
--- a/clippy_lints/src/manual_is_ascii_check.rs
+++ b/clippy_lints/src/manual_is_ascii_check.rs
@@ -91,15 +91,16 @@ impl<'tcx> LateLintPass<'tcx> for ManualIsAsciiCheck {
                     CharRange::Digit => Some("is_ascii_digit"),
                     CharRange::Otherwise => None,
                 } {
-                    let mut applicability = Applicability::MaybeIncorrect;
                     let default_snip = "..";
                     // `snippet_with_applicability` may set applicability to `MaybeIncorrect` for
-                    // macro span, so we check applicability manually by comaring `recv` is not default.
+                    // macro span, so we check applicability manually by comparing `recv` is not default.
                     let recv = snippet(cx, recv.span, default_snip);
 
-                    if recv != default_snip {
-                        applicability = Applicability::MachineApplicable;
-                    }
+                    let applicability = if recv == default_snip {
+                        Applicability::HasPlaceholders
+                    } else {
+                        Applicability::MachineApplicable
+                    };
 
                     span_lint_and_sugg(
                         cx,