about summary refs log tree commit diff
diff options
context:
space:
mode:
authorJames Farrell <jamesfarrell@google.com>2023-03-21 17:12:02 +0000
committerJames Farrell <jamesfarrell@google.com>2023-03-21 17:12:02 +0000
commit75718081ee140ad9b18281cc5319a9436101b9da (patch)
tree2a0a6e22e234673e0d94c5c1f0c9504b1348ddb3
parenta01b4cc9f375f1b95fa8195daeea938d3d9c4c34 (diff)
downloadrust-75718081ee140ad9b18281cc5319a9436101b9da.tar.gz
rust-75718081ee140ad9b18281cc5319a9436101b9da.zip
Ignore the vendor directory for tidy tests.
When running `x.py test` on a downloaded source distribution (e.g.
https://static.rust-lang.org/dist/rustc-<version>-src.tar.gz), the
crates in the vendor directory contain a number of executable files that
cause the tidy test to fail with the following message:

tidy error: binary checked into source: <path>

I see 26 such errors with the 1.68.0 source distribution. A few of these
are .rs source files with incorrect executable permission, but most are
scripts that are correctly marked executable.
-rw-r--r--src/tools/tidy/src/walk.rs1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/tools/tidy/src/walk.rs b/src/tools/tidy/src/walk.rs
index 2ade22c209f..67a4df19fcc 100644
--- a/src/tools/tidy/src/walk.rs
+++ b/src/tools/tidy/src/walk.rs
@@ -29,6 +29,7 @@ pub fn filter_dirs(path: &Path) -> bool {
         // Filter RLS output directories
         "target/rls",
         "src/bootstrap/target",
+        "vendor",
     ];
     skip.iter().any(|p| path.ends_with(p))
 }