about summary refs log tree commit diff
diff options
context:
space:
mode:
authoronur-ozkan <work@onurozkan.dev>2025-04-28 06:49:38 +0300
committeronur-ozkan <work@onurozkan.dev>2025-04-28 06:49:38 +0300
commit7669d5011977eef757bb4cd9437b6aef50f4b3f6 (patch)
treeab3a6c43cdcb7095b8f7290b7a158638033057a9
parent8290766bbee6a9ce384d0e7527c46001392ed423 (diff)
downloadrust-7669d5011977eef757bb4cd9437b6aef50f4b3f6.tar.gz
rust-7669d5011977eef757bb4cd9437b6aef50f4b3f6.zip
add a FIXME
Signed-off-by: onur-ozkan <work@onurozkan.dev>
-rw-r--r--src/bootstrap/src/core/builder/cargo.rs5
1 files changed, 3 insertions, 2 deletions
diff --git a/src/bootstrap/src/core/builder/cargo.rs b/src/bootstrap/src/core/builder/cargo.rs
index 149a19d9d88..5d3f7c9cc76 100644
--- a/src/bootstrap/src/core/builder/cargo.rs
+++ b/src/bootstrap/src/core/builder/cargo.rs
@@ -112,8 +112,7 @@ impl Cargo {
         let mut cargo = builder.cargo(compiler, mode, source_type, target, cmd_kind);
 
         match cmd_kind {
-            // No need to configure the target linker for these command types,
-            // as they don't invoke rustc at all.
+            // No need to configure the target linker for these command types.
             Kind::Clean | Kind::Check | Kind::Suggest | Kind::Format | Kind::Setup => {}
             _ => {
                 cargo.configure_linker(builder);
@@ -205,6 +204,8 @@ impl Cargo {
         self
     }
 
+    // FIXME(onur-ozkan): Add coverage to make sure modifications to this function
+    // doesn't cause cache invalidations (e.g., #130108).
     fn configure_linker(&mut self, builder: &Builder<'_>) -> &mut Cargo {
         let target = self.target;
         let compiler = self.compiler;