diff options
| author | Guillaume Gomez <guillaume1.gomez@gmail.com> | 2025-01-04 12:55:09 +0100 |
|---|---|---|
| committer | Guillaume Gomez <guillaume1.gomez@gmail.com> | 2025-01-06 17:35:55 +0100 |
| commit | 78225ccca8980e357123ac936655a40e0b0c8b8f (patch) | |
| tree | 889d4601144fbfa7f1e74e765d65290e7f7842ef | |
| parent | 891e38788a36c3d217e4e06d52e4ee67797b8ccb (diff) | |
| download | rust-78225ccca8980e357123ac936655a40e0b0c8b8f.tar.gz rust-78225ccca8980e357123ac936655a40e0b0c8b8f.zip | |
Add regression test for #8528
| -rw-r--r-- | tests/ui/map_flatten.rs | 12 | ||||
| -rw-r--r-- | tests/ui/map_flatten.stderr | 11 |
2 files changed, 22 insertions, 1 deletions
diff --git a/tests/ui/map_flatten.rs b/tests/ui/map_flatten.rs index 76916d46591..eafc8b6e81c 100644 --- a/tests/ui/map_flatten.rs +++ b/tests/ui/map_flatten.rs @@ -55,6 +55,18 @@ fn long_span() { .collect(); } +#[allow(clippy::useless_vec)] +fn no_suggestion_if_comments_present() { + let vec = vec![vec![1, 2, 3]]; + let _ = vec + .iter() + // a lovely comment explaining the code in very detail + .map(|x| x.iter()) + //~^ ERROR: called `map(..).flatten()` on `Iterator` + // the answer to life, the universe and everything could be here + .flatten(); +} + fn main() { long_span(); } diff --git a/tests/ui/map_flatten.stderr b/tests/ui/map_flatten.stderr index a5837b97617..34bd174d7dd 100644 --- a/tests/ui/map_flatten.stderr +++ b/tests/ui/map_flatten.stderr @@ -102,5 +102,14 @@ LL + } LL + }) | -error: aborting due to 4 previous errors +error: called `map(..).flatten()` on `Iterator` + --> tests/ui/map_flatten.rs:64:10 + | +LL | .map(|x| x.iter()) + | __________^ +... | +LL | | .flatten(); + | |__________________^ help: try replacing `map` with `flat_map` and remove the `.flatten()`: `flat_map(|x| x.iter())` + +error: aborting due to 5 previous errors |
