about summary refs log tree commit diff
diff options
context:
space:
mode:
authorMatthias Krüger <matthias.krueger@famsik.de>2024-02-12 23:18:52 +0100
committerGitHub <noreply@github.com>2024-02-12 23:18:52 +0100
commit78403e86d5dc0ff451201d7d7a1d248476c58f83 (patch)
tree788661164d4aa0fcdc149caf44b9561be1354c5e
parent74f5e1f14071063f9a2708990192379678731802 (diff)
parent4a2939bcd24f6bf81bd8e1e82f349c783bca89e0 (diff)
downloadrust-78403e86d5dc0ff451201d7d7a1d248476c58f83.tar.gz
rust-78403e86d5dc0ff451201d7d7a1d248476c58f83.zip
Rollup merge of #119451 - Kobzol:ci-pr-clippy, r=Mark-Simulacrum
Gate PR CI on clippy correctness lints

Implements part of https://github.com/rust-lang/compiler-team/issues/709.

Note that `x.py clippy compiler` also checks the standard library, because it needs to be checked before the compiler. This happens even with `x.py clippy --stage 0`.
-rw-r--r--src/ci/docker/host-x86_64/mingw-check/Dockerfile6
1 files changed, 1 insertions, 5 deletions
diff --git a/src/ci/docker/host-x86_64/mingw-check/Dockerfile b/src/ci/docker/host-x86_64/mingw-check/Dockerfile
index f8fcda5070f..30d3a52d82b 100644
--- a/src/ci/docker/host-x86_64/mingw-check/Dockerfile
+++ b/src/ci/docker/host-x86_64/mingw-check/Dockerfile
@@ -40,13 +40,9 @@ COPY host-x86_64/mingw-check/validate-error-codes.sh /scripts/
 
 ENV RUN_CHECK_WITH_PARALLEL_QUERIES 1
 
-# Run clippy just to make sure it doesn't error out; we don't actually want to gate on the warnings
-# though.
-# Ideally we'd use stage 1, but that ICEs: https://github.com/rust-lang/rust-clippy/issues/11230
-
 ENV SCRIPT python3 ../x.py --stage 2 test src/tools/expand-yaml-anchors && \
            python3 ../x.py check --target=i686-pc-windows-gnu --host=i686-pc-windows-gnu && \
-           python3 ../x.py clippy --stage 0 -Awarnings && \
+           python3 ../x.py clippy compiler -Aclippy::all -Dclippy::correctness && \
            python3 ../x.py build --stage 0 src/tools/build-manifest && \
            python3 ../x.py test --stage 0 src/tools/compiletest && \
            python3 ../x.py test --stage 0 core alloc std test proc_macro && \