about summary refs log tree commit diff
diff options
context:
space:
mode:
authorMichael Goulet <michael@errs.io>2024-01-06 21:51:47 -0500
committerGitHub <noreply@github.com>2024-01-06 21:51:47 -0500
commit79475c0b06070e5f3fb81edd99e0b95447c41b09 (patch)
treec43deec5cc04f6e8b8298f75ea709c4ce89c9c74
parent854d1131ff33d437aae5fa6fcfdf0cbbaae3067b (diff)
parent373aeed24d86a6ece0a1d7a067fcc83a6c5bd41a (diff)
downloadrust-79475c0b06070e5f3fb81edd99e0b95447c41b09.tar.gz
rust-79475c0b06070e5f3fb81edd99e0b95447c41b09.zip
Rollup merge of #119679 - compiler-errors:issue-templates, r=Mark-Simulacrum
Ask for rustc version in diagnostic reports, remind users to update their toolchain

IDK why we don't ask for rustc toolchain when filing diagnostic issues. Diagnostics are sometimes very dramatically affected by compiler version, and users may report old diagnostic issues that were fixed by subsequent rustc versions that they have yet to update to.

For example, #119678 was made a bit more difficult to triage due to the template not asking the issuer to report their rustc version.
-rw-r--r--.github/ISSUE_TEMPLATE/diagnostics.yaml19
-rw-r--r--.github/ISSUE_TEMPLATE/ice.yaml2
2 files changed, 17 insertions, 4 deletions
diff --git a/.github/ISSUE_TEMPLATE/diagnostics.yaml b/.github/ISSUE_TEMPLATE/diagnostics.yaml
index 873fbaaf654..54bf2bc6ee2 100644
--- a/.github/ISSUE_TEMPLATE/diagnostics.yaml
+++ b/.github/ISSUE_TEMPLATE/diagnostics.yaml
@@ -52,10 +52,23 @@ body:
       render: Rust
     validations:
       required: false
-  - type: markdown
+  - type: textarea
+    id: version
     attributes:
-      value: |
-        If you're using the stable version of the compiler, you should also check if the bug also exists in the beta or nightly versions. The output might also be different depending on the Edition.
+      label: Rust Version
+      description: Please provide the `rustc` version, `rustc --version --verbose`. Make sure that you're using the latest version of the compiler, and not an outdated stable or nightly release!
+      placeholder: |
+        $ rustc --version --verbose
+        rustc 1.XX.Y (SHORTHASH DATE)
+        binary: rustc
+        commit-hash: LONGHASHVALUE
+        commit-date: DATE
+        host: PLATFORMTRIPLE
+        release: 1.XX.Y
+        LLVM version: XX.YY.ZZ
+      render: Shell
+    validations:
+      required: true
   - type: textarea
     id: extra
     attributes:
diff --git a/.github/ISSUE_TEMPLATE/ice.yaml b/.github/ISSUE_TEMPLATE/ice.yaml
index 7bec05cc575..13be13d4f99 100644
--- a/.github/ISSUE_TEMPLATE/ice.yaml
+++ b/.github/ISSUE_TEMPLATE/ice.yaml
@@ -40,7 +40,7 @@ body:
     id: version
     attributes:
       label: Rust Version
-      description: Please provide the `rustc` version, `rustc --version --verbose`
+      description: Please provide the `rustc` version, `rustc --version --verbose`. Make sure that you're using the latest version of the compiler, and not an outdated stable or nightly release!
       placeholder: |
         $ rustc --version --verbose
         rustc 1.XX.Y (SHORTHASH DATE)