about summary refs log tree commit diff
diff options
context:
space:
mode:
authorAmos Wenger <amoswenger@gmail.com>2022-05-22 18:31:12 +0200
committerAmos Wenger <amoswenger@gmail.com>2022-05-22 18:31:12 +0200
commit796c4d8a10359bc8add6e5acf952c87f4354189b (patch)
tree7d7e9add3971cc3f83880f883a5547d04ef354d9
parent707a5683b1016f70f153ee43f75a6d1c6b9d012d (diff)
downloadrust-796c4d8a10359bc8add6e5acf952c87f4354189b.tar.gz
rust-796c4d8a10359bc8add6e5acf952c87f4354189b.zip
Better lowercase/uppercase checks
-rw-r--r--crates/ide-assists/src/handlers/generate_enum_variant.rs2
-rw-r--r--crates/ide-assists/src/handlers/generate_function.rs2
2 files changed, 2 insertions, 2 deletions
diff --git a/crates/ide-assists/src/handlers/generate_enum_variant.rs b/crates/ide-assists/src/handlers/generate_enum_variant.rs
index 3b28a9639c8..eaf6f047c73 100644
--- a/crates/ide-assists/src/handlers/generate_enum_variant.rs
+++ b/crates/ide-assists/src/handlers/generate_enum_variant.rs
@@ -41,7 +41,7 @@ pub(crate) fn generate_enum_variant(acc: &mut Assists, ctx: &AssistContext) -> O
     }
 
     let name_ref = path.segment()?.name_ref()?;
-    if name_ref.text().as_str().chars().next()?.is_ascii_lowercase() {
+    if name_ref.text().starts_with(char::is_lowercase) {
         // Don't suggest generating variant if the name starts with a lowercase letter
         return None;
     }
diff --git a/crates/ide-assists/src/handlers/generate_function.rs b/crates/ide-assists/src/handlers/generate_function.rs
index 7077dc9e5c7..c8650979e95 100644
--- a/crates/ide-assists/src/handlers/generate_function.rs
+++ b/crates/ide-assists/src/handlers/generate_function.rs
@@ -73,7 +73,7 @@ fn gen_fn(acc: &mut Assists, ctx: &AssistContext) -> Option<()> {
             Some(hir::PathResolution::Def(hir::ModuleDef::Adt(adt))) => {
                 if let hir::Adt::Enum(_) = adt {
                     // Don't suggest generating function if the name starts with an uppercase letter
-                    if name_ref.text().chars().next()?.is_uppercase() {
+                    if name_ref.text().starts_with(char::is_uppercase) {
                         return None;
                     }
                 }