about summary refs log tree commit diff
diff options
context:
space:
mode:
authorJeffrey Seyfried <jeffrey.seyfried@gmail.com>2015-12-18 10:10:31 +0000
committerJeffrey Seyfried <jeffrey.seyfried@gmail.com>2016-01-31 02:21:54 +0000
commit7a69ee0c4806d30bbda5cc0277f3d0f38c3266c8 (patch)
tree274c80c79335e7d39e44627220d59e6a1fff2f94
parent9a07087bc5533f4dc7318ea15d9fb4822c0ba67b (diff)
downloadrust-7a69ee0c4806d30bbda5cc0277f3d0f38c3266c8.tar.gz
rust-7a69ee0c4806d30bbda5cc0277f3d0f38c3266c8.zip
Revert PR #30324, fixing a bug in which a public glob import can make preceding imports public (fixes #30159).
-rw-r--r--src/librustc_resolve/resolve_imports.rs3
-rw-r--r--src/test/compile-fail/shadowed-use-visibility.rs4
2 files changed, 4 insertions, 3 deletions
diff --git a/src/librustc_resolve/resolve_imports.rs b/src/librustc_resolve/resolve_imports.rs
index 07f6a0f9549..50537a6b936 100644
--- a/src/librustc_resolve/resolve_imports.rs
+++ b/src/librustc_resolve/resolve_imports.rs
@@ -798,9 +798,6 @@ impl<'a, 'b:'a, 'tcx:'b> ImportResolver<'a, 'b, 'tcx> {
                 dest_import_resolution.is_public = is_public;
                 self.add_export(module_, name, &dest_import_resolution);
             }
-        } else {
-            // FIXME #30159: This is required for backwards compatability.
-            dest_import_resolution.is_public |= is_public;
         }
 
         self.check_for_conflicts_between_imports_and_items(module_,
diff --git a/src/test/compile-fail/shadowed-use-visibility.rs b/src/test/compile-fail/shadowed-use-visibility.rs
index bfc6a4ec9b8..1bf7f393384 100644
--- a/src/test/compile-fail/shadowed-use-visibility.rs
+++ b/src/test/compile-fail/shadowed-use-visibility.rs
@@ -17,6 +17,10 @@ mod foo {
 
 mod bar {
     use foo::bar::f as g; //~ ERROR unresolved import
+
+    use foo as f;
+    pub use foo::*;
 }
 
+use bar::f::f; //~ ERROR unresolved import
 fn main() {}