diff options
| author | Laurențiu Nicola <lnicola@users.noreply.github.com> | 2025-01-23 12:09:49 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-01-23 12:09:49 +0000 |
| commit | 7ba18daca727a5eaa283ef044841eef0e7fd156d (patch) | |
| tree | 7cff15f16e4be9e78e6d9973a268d26f22342940 | |
| parent | 3ca106683ea652a3e18b91f6452324a2d71fcdeb (diff) | |
| parent | a32f64dc307192d7880212f691ff64007dee711e (diff) | |
| download | rust-7ba18daca727a5eaa283ef044841eef0e7fd156d.tar.gz rust-7ba18daca727a5eaa283ef044841eef0e7fd156d.zip | |
Merge pull request #19009 from lnicola/dont-just-die
minor: Rephrase comment
| -rw-r--r-- | src/tools/rust-analyzer/lib/lsp-server/src/msg.rs | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/tools/rust-analyzer/lib/lsp-server/src/msg.rs b/src/tools/rust-analyzer/lib/lsp-server/src/msg.rs index 074bc43388a..2749557b91a 100644 --- a/src/tools/rust-analyzer/lib/lsp-server/src/msg.rs +++ b/src/tools/rust-analyzer/lib/lsp-server/src/msg.rs @@ -80,9 +80,9 @@ pub struct Request { #[derive(Debug, Serialize, Deserialize, Clone)] pub struct Response { - // JSON RPC allows this to be null if it was impossible - // to decode the request's id. Ignore this special case - // and just die horribly. + // JSON-RPC allows this to be null if we can't find or parse the + // request id. We fail deserialization in that case, so we just + // make this field mandatory. pub id: RequestId, #[serde(skip_serializing_if = "Option::is_none")] pub result: Option<serde_json::Value>, |