about summary refs log tree commit diff
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2024-07-08 08:29:18 +0000
committerbors <bors@rust-lang.org>2024-07-08 08:29:18 +0000
commit7e3303de2ffafb342489fc0c7d6e336f30781c20 (patch)
treeac72c69729ae3cab4dad73f2fb1b726f3c33a638
parentfafacf3e9a7b11ac56e435bd98c05b2722eab906 (diff)
parent4b482bc90d11a4e46155c6c0423d0cd30a64151c (diff)
Auto merge of #17561 - mo8it:keep-going, r=Veykril
Add --keep-going to the check command

Fixes https://github.com/rust-lang/rustlings/issues/1628

`@Veykril` I am not sure about what you meant with "unconditionally" in https://github.com/rust-lang/rustlings/issues/1628#issuecomment-2212492230, but I didn't find out how to get the version of the toolchain anyway to do a check like in [this snippet](https://github.com/rust-lang/rust-analyzer/blob/a5b21ea0aa644dffd7cf958b43f11f221d53404e/crates/project-model/src/build_scripts.rs#L125-L127). Is this check even required if rust-analyzer was installed with the toolchain?

`--keep-going` was [stabilized in 1.74](https://github.com/rust-lang/cargo/blob/master/CHANGELOG.md#cargo-174-2023-11-16)
-rw-r--r--src/tools/rust-analyzer/crates/flycheck/src/lib.rs2
1 files changed, 2 insertions, 0 deletions
diff --git a/src/tools/rust-analyzer/crates/flycheck/src/lib.rs b/src/tools/rust-analyzer/crates/flycheck/src/lib.rs
index a257633516c..778def5d2be 100644
--- a/src/tools/rust-analyzer/crates/flycheck/src/lib.rs
+++ b/src/tools/rust-analyzer/crates/flycheck/src/lib.rs
@@ -426,6 +426,8 @@ impl FlycheckActor {
                     }
                 }
 
+                cmd.arg("--keep-going");
+
                 options.apply_on_command(&mut cmd);
                 (cmd, options.extra_args.clone())
             }