diff options
| author | David Tolnay <dtolnay@gmail.com> | 2023-12-27 17:30:54 -0800 |
|---|---|---|
| committer | David Tolnay <dtolnay@gmail.com> | 2024-05-11 15:49:01 -0700 |
| commit | 7f2ffbdbc6c0d5e1c7fabe0bef56ec49d10bfeab (patch) | |
| tree | 9b94dfcc460f6556255f7e3502e3742d729ff5e5 | |
| parent | c5a0eb12466b6591bc3a3d373c51fabd19735533 (diff) | |
| download | rust-7f2ffbdbc6c0d5e1c7fabe0bef56ec49d10bfeab.tar.gz rust-7f2ffbdbc6c0d5e1c7fabe0bef56ec49d10bfeab.zip | |
Fix pretty printer statement boundaries after braced macro call
| -rw-r--r-- | compiler/rustc_ast_pretty/src/pprust/state/fixup.rs | 6 | ||||
| -rw-r--r-- | tests/ui/macros/stringify.rs | 4 |
2 files changed, 3 insertions, 7 deletions
diff --git a/compiler/rustc_ast_pretty/src/pprust/state/fixup.rs b/compiler/rustc_ast_pretty/src/pprust/state/fixup.rs index 9934f972f9b..d21cb82f83b 100644 --- a/compiler/rustc_ast_pretty/src/pprust/state/fixup.rs +++ b/compiler/rustc_ast_pretty/src/pprust/state/fixup.rs @@ -128,11 +128,7 @@ impl FixupContext { /// The documentation on `FixupContext::leftmost_subexpression_in_stmt` has /// examples. pub fn would_cause_statement_boundary(self, expr: &Expr) -> bool { - self.leftmost_subexpression_in_stmt - && match expr.kind { - ExprKind::MacCall(_) => false, - _ => !classify::expr_requires_semi_to_be_stmt(expr), - } + self.leftmost_subexpression_in_stmt && !classify::expr_requires_semi_to_be_stmt(expr) } /// Determine whether parentheses are needed around the given `let` diff --git a/tests/ui/macros/stringify.rs b/tests/ui/macros/stringify.rs index df1cf5d8a91..a66a5513ffa 100644 --- a/tests/ui/macros/stringify.rs +++ b/tests/ui/macros/stringify.rs @@ -225,7 +225,7 @@ fn test_expr() { ); c2_match_arm!( [ m! {} - 1 ], - "match () { _ => m! {} - 1, }", + "match () { _ => (m! {}) - 1, }", // parenthesis is redundant "match () { _ => m! {} - 1 }", ); @@ -747,7 +747,7 @@ fn test_stmt() { ); c2_minus_one!( [ m! {} ], - "m! {} - 1;", // FIXME(dtolnay): needs parens, otherwise this is 2 separate statements + "(m! {}) - 1;", "m! {} - 1" ); |
