diff options
| author | Vadim Petrochenkov <vadim.petrochenkov@gmail.com> | 2020-04-12 23:36:37 +0300 |
|---|---|---|
| committer | Vadim Petrochenkov <vadim.petrochenkov@gmail.com> | 2020-04-13 18:37:51 +0300 |
| commit | 8392e477e73c12566803411396b0ff18a0864c81 (patch) | |
| tree | c9907a6f38708702d0c41ae879b6b42d29e99cab | |
| parent | 57870ea2ca2f9795e875d55d60df57d47e4a3eba (diff) | |
| download | rust-8392e477e73c12566803411396b0ff18a0864c81.tar.gz rust-8392e477e73c12566803411396b0ff18a0864c81.zip | |
Address review comments
| -rw-r--r-- | src/librustc_target/spec/msvc_base.rs | 3 | ||||
| -rw-r--r-- | src/librustc_target/spec/windows_uwp_gnu_base.rs | 2 |
2 files changed, 1 insertions, 4 deletions
diff --git a/src/librustc_target/spec/msvc_base.rs b/src/librustc_target/spec/msvc_base.rs index 4d921b5d5fe..817a322a9e4 100644 --- a/src/librustc_target/spec/msvc_base.rs +++ b/src/librustc_target/spec/msvc_base.rs @@ -27,9 +27,6 @@ pub fn opts() -> TargetOptions { link_env: vec![("VSLANG".to_string(), "1033".to_string())], lld_flavor: LldFlavor::Link, pre_link_args, - // UEFI mirrors the calling-conventions used on windows. In case of x86-64 and i686 this - // means small structs will be returned as int. This shouldn't matter much, since the - // restrictions placed by the UEFI specifications forbid any ABI to return structures. abi_return_struct_as_int: true, emit_debug_gdb_scripts: false, diff --git a/src/librustc_target/spec/windows_uwp_gnu_base.rs b/src/librustc_target/spec/windows_uwp_gnu_base.rs index aa99c3f7d95..dd3b60344be 100644 --- a/src/librustc_target/spec/windows_uwp_gnu_base.rs +++ b/src/librustc_target/spec/windows_uwp_gnu_base.rs @@ -16,7 +16,7 @@ pub fn opts() -> TargetOptions { ], ); - // FIXME: Should UWP target be updated for the exception machinery changes from #67502? + // FIXME: This should be updated for the exception machinery changes from #67502. let mut late_link_args = LinkArgs::new(); let late_link_args_dynamic = LinkArgs::new(); let late_link_args_static = LinkArgs::new(); |