diff options
| author | Nicholas Nethercote <n.nethercote@gmail.com> | 2024-11-22 06:20:53 +1100 |
|---|---|---|
| committer | Nicholas Nethercote <n.nethercote@gmail.com> | 2024-12-16 09:24:46 +1100 |
| commit | 848610fddc127b8fa44c5c40d336bc10ee34e563 (patch) | |
| tree | 8ff8590f408ea7436c744dde49b85d3b4543ebe0 | |
| parent | d18506299bfb20488aba466a69641a2bab6f7a4a (diff) | |
| download | rust-848610fddc127b8fa44c5c40d336bc10ee34e563.tar.gz rust-848610fddc127b8fa44c5c40d336bc10ee34e563.zip | |
Add a comment to `MaybeInitializedPlaces::apply_terminator_effect`.
I tried reordering this method to more closely match `MaybeUninitializedPlaces::apply_terminator_effect`, but doing so breaks tests.
| -rw-r--r-- | compiler/rustc_mir_dataflow/src/impls/initialized.rs | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/compiler/rustc_mir_dataflow/src/impls/initialized.rs b/compiler/rustc_mir_dataflow/src/impls/initialized.rs index fb02408e17d..9fdbbb1578e 100644 --- a/compiler/rustc_mir_dataflow/src/impls/initialized.rs +++ b/compiler/rustc_mir_dataflow/src/impls/initialized.rs @@ -293,6 +293,8 @@ impl<'tcx> Analysis<'tcx> for MaybeInitializedPlaces<'_, 'tcx> { terminator: &'mir mir::Terminator<'tcx>, location: Location, ) -> TerminatorEdges<'mir, 'tcx> { + // Note: `edges` must be computed first because `drop_flag_effects_for_location` can change + // the result of `is_unwind_dead`. let mut edges = terminator.edges(); if self.skip_unreachable_unwind && let mir::TerminatorKind::Drop { target, unwind, place, replace: _ } = terminator.kind |