about summary refs log tree commit diff
diff options
context:
space:
mode:
authorJakub Beránek <berykubik@gmail.com>2023-08-04 10:40:14 +0200
committerJakub Beránek <berykubik@gmail.com>2023-08-04 10:40:14 +0200
commit88b99851a2b06be72152e0bc294d46500d17c7ee (patch)
treed8e99bb3f9e1b7161d35205f6db31ca6356401fa
parent2e6ac7fe5bb96bcc2d8c0b3e20db7cf7d2baa241 (diff)
downloadrust-88b99851a2b06be72152e0bc294d46500d17c7ee.tar.gz
rust-88b99851a2b06be72152e0bc294d46500d17c7ee.zip
Print GHA log groups to stdout instead of stderr
In all other places (e.g. `bootstrap.py`, `opt-dist`), we use stdout instead of stderr. I think that using stderr might be causing some discrepancies in the log, where sometimes the contents of a group "leak" outside the group. Let's see what happens if we use stdout instead. It's possible that it will be worse, since we print most stuff to stderr (?).
-rw-r--r--src/tools/build_helper/src/ci.rs6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/tools/build_helper/src/ci.rs b/src/tools/build_helper/src/ci.rs
index a8505ec9596..09489b0d9b7 100644
--- a/src/tools/build_helper/src/ci.rs
+++ b/src/tools/build_helper/src/ci.rs
@@ -82,15 +82,15 @@ pub mod gha {
 
     fn start_group(name: impl std::fmt::Display) {
         if is_in_gha() {
-            eprintln!("::group::{name}");
+            println!("::group::{name}");
         } else {
-            eprintln!("{name}")
+            println!("{name}")
         }
     }
 
     fn end_group() {
         if is_in_gha() {
-            eprintln!("::endgroup::");
+            println!("::endgroup::");
         }
     }