diff options
| author | Victor Berger <victor.berger@m4x.org> | 2015-07-31 10:22:13 +0200 |
|---|---|---|
| committer | Victor Berger <victor.berger@m4x.org> | 2015-07-31 19:10:14 +0200 |
| commit | 88c2914e56fe54f2179c37914a7d61c7fe4a2605 (patch) | |
| tree | 2cbadb5fe35ceb3ac76dc07eba635b9e02182713 | |
| parent | 0919f4ad862bc3ae771fc56a8fe9905bca299fe2 (diff) | |
| download | rust-88c2914e56fe54f2179c37914a7d61c7fe4a2605.tar.gz rust-88c2914e56fe54f2179c37914a7d61c7fe4a2605.zip | |
Remove unused resolve error message.
There is not situation where `foo` would be unresolved but not `foo::*`.
| -rw-r--r-- | src/librustc_resolve/lib.rs | 21 | ||||
| -rw-r--r-- | src/librustc_resolve/resolve_imports.rs | 2 |
2 files changed, 6 insertions, 17 deletions
diff --git a/src/librustc_resolve/lib.rs b/src/librustc_resolve/lib.rs index fa9c7a2038c..f66dfa83ff9 100644 --- a/src/librustc_resolve/lib.rs +++ b/src/librustc_resolve/lib.rs @@ -176,7 +176,7 @@ pub enum ResolutionError<'a> { /// error E0431: `self` import can only appear in an import list with a non-empty prefix SelfImportOnlyInImportListWithNonEmptyPrefix, /// error E0432: unresolved import - UnresolvedImport(Option<(&'a str, Option<&'a str>)>), + UnresolvedImport(Option<(&'a str, &'a str)>), /// error E0433: failed to resolve FailedToResolve(&'a str), /// error E0434: can't capture dynamic environment in a fn item @@ -359,8 +359,7 @@ fn resolve_error<'b, 'a:'b, 'tcx:'a>(resolver: &'b Resolver<'a, 'tcx>, span: syn } ResolutionError::UnresolvedImport(name) => { let msg = match name { - Some((n, Some(p))) => format!("unresolved import `{}`{}", n, p), - Some((n, None)) => format!("unresolved import (maybe you meant `{}::*`?)", n), + Some((n, p)) => format!("unresolved import `{}`{}", n, p), None => "unresolved import".to_owned() }; span_err!(resolver.session, span, E0432, "{}", msg); @@ -1815,19 +1814,9 @@ impl<'a, 'tcx> Resolver<'a, 'tcx> { let imports = module_.imports.borrow(); let import_count = imports.len(); if index != import_count { - let sn = self.session - .codemap() - .span_to_snippet((*imports)[index].span) - .unwrap(); - if sn.contains("::") { - resolve_error(self, - (*imports)[index].span, - ResolutionError::UnresolvedImport(None)); - } else { - resolve_error(self, - (*imports)[index].span, - ResolutionError::UnresolvedImport(Some((&*sn, None)))); - } + resolve_error(self, + (*imports)[index].span, + ResolutionError::UnresolvedImport(None)); } // Descend into children and anonymous children. diff --git a/src/librustc_resolve/resolve_imports.rs b/src/librustc_resolve/resolve_imports.rs index 0a88a3c0aef..a9ad0cf137b 100644 --- a/src/librustc_resolve/resolve_imports.rs +++ b/src/librustc_resolve/resolve_imports.rs @@ -278,7 +278,7 @@ impl<'a, 'b:'a, 'tcx:'b> ImportResolver<'a, 'b, 'tcx> { Some((&*import_path_to_string( &import_directive.module_path, import_directive.subclass), - Some(&*help)))) + &*help))) ); } ResolveResult::Indeterminate => break, // Bail out. We'll come around next time. |
