about summary refs log tree commit diff
diff options
context:
space:
mode:
authorbjorn3 <17426603+bjorn3@users.noreply.github.com>2024-11-08 16:16:03 +0100
committerbjorn3 <17426603+bjorn3@users.noreply.github.com>2024-11-08 16:43:25 +0100
commit8a0053e9e16586e060612db44578038d3edb107e (patch)
tree2220be3150989177ace881aa38d6afe908680178
parentc637a84ad4f4446e6f6bbb1129632b20b42c6e3a (diff)
Use a BufWriter in emit_module to reduce syscall overhead
For the coercions rustc-perf benchmark without this commit reduces the
total amount of time it takes to emit the object file from 270ms to
27ms.
-rw-r--r--src/driver/aot.rs8
1 files changed, 7 insertions, 1 deletions
diff --git a/src/driver/aot.rs b/src/driver/aot.rs
index 419efa90600..8eab73ad5f9 100644
--- a/src/driver/aot.rs
+++ b/src/driver/aot.rs
@@ -2,6 +2,7 @@
 //! standalone executable.
 
 use std::fs::{self, File};
+use std::io::BufWriter;
 use std::path::{Path, PathBuf};
 use std::sync::Arc;
 use std::thread::JoinHandle;
@@ -397,14 +398,19 @@ fn emit_module(
     }
 
     let tmp_file = output_filenames.temp_path(OutputType::Object, Some(&name));
-    let mut file = match File::create(&tmp_file) {
+    let file = match File::create(&tmp_file) {
         Ok(file) => file,
         Err(err) => return Err(format!("error creating object file: {}", err)),
     };
 
+    let mut file = BufWriter::new(file);
     if let Err(err) = object.write_stream(&mut file) {
         return Err(format!("error writing object file: {}", err));
     }
+    let file = match file.into_inner() {
+        Ok(file) => file,
+        Err(err) => return Err(format!("error writing object file: {}", err)),
+    };
 
     prof.artifact_size("object_file", &*name, file.metadata().unwrap().len());