about summary refs log tree commit diff
diff options
context:
space:
mode:
authorDavid Wood <david@davidtw.co>2019-04-25 07:53:06 +0100
committerDavid Wood <david@davidtw.co>2019-04-25 07:53:06 +0100
commit8a47e088458866b6dd8aa28acc9db1e9e22be997 (patch)
treec6760e385568980e8c499af114e7f584e6b91e99
parente305df1846a6d985315917ae0c81b74af8b4e641 (diff)
downloadrust-8a47e088458866b6dd8aa28acc9db1e9e22be997.tar.gz
rust-8a47e088458866b6dd8aa28acc9db1e9e22be997.zip
Add test for current behaviour.
This commit adds a test that causes a suggestion to replace `extern
crate` with `use` when doing so would cause a compliation error, as the
new name of the import would not be added to the prelude if a `use` was
used.
-rw-r--r--src/test/ui/suggestions/issue-57672.rs14
-rw-r--r--src/test/ui/suggestions/issue-57672.stderr14
2 files changed, 28 insertions, 0 deletions
diff --git a/src/test/ui/suggestions/issue-57672.rs b/src/test/ui/suggestions/issue-57672.rs
new file mode 100644
index 00000000000..c8ea6e59582
--- /dev/null
+++ b/src/test/ui/suggestions/issue-57672.rs
@@ -0,0 +1,14 @@
+// aux-build:foo.rs
+// compile-flags:--extern foo
+// edition:2018
+
+#![deny(unused_extern_crates)]
+
+extern crate foo as foo_renamed;
+//~^ ERROR `extern crate` is not idiomatic in the new edition
+
+pub mod m {
+    pub use foo_renamed::Foo;
+}
+
+fn main() {}
diff --git a/src/test/ui/suggestions/issue-57672.stderr b/src/test/ui/suggestions/issue-57672.stderr
new file mode 100644
index 00000000000..c9e4c373799
--- /dev/null
+++ b/src/test/ui/suggestions/issue-57672.stderr
@@ -0,0 +1,14 @@
+error: `extern crate` is not idiomatic in the new edition
+  --> $DIR/issue-57672.rs:7:1
+   |
+LL | extern crate foo as foo_renamed;
+   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert it to a `use`
+   |
+note: lint level defined here
+  --> $DIR/issue-57672.rs:5:9
+   |
+LL | #![deny(unused_extern_crates)]
+   |         ^^^^^^^^^^^^^^^^^^^^
+
+error: aborting due to previous error
+