about summary refs log tree commit diff
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2020-04-17 01:40:59 +0000
committerbors <bors@rust-lang.org>2020-04-17 01:40:59 +0000
commit8ae143fcd07258dfc381d26337020253fedd322f (patch)
tree22d3e8a29ee44c5e321e7e5c4d1154867e96f1bd
parenteb9c15a6b38d6b1a64f7e6a1360d533014c0e797 (diff)
parent162cf261dc1874ec1b7b684b3fd6193c2c8460be (diff)
downloadrust-8ae143fcd07258dfc381d26337020253fedd322f.tar.gz
rust-8ae143fcd07258dfc381d26337020253fedd322f.zip
Auto merge of #5480 - sinkuu:unit_arg_app, r=flip1995
unit_arg suggestion is not really machine-applicable

This lint suggests replacing any code returining `()`-type with `()` literal, which can change the behavior. e.g. `Ok(do_something())` -> `OK(())`.

---

changelog: none
-rw-r--r--clippy_lints/src/types.rs2
1 files changed, 1 insertions, 1 deletions
diff --git a/clippy_lints/src/types.rs b/clippy_lints/src/types.rs
index 14f4ea154eb..09d5e6bd43d 100644
--- a/clippy_lints/src/types.rs
+++ b/clippy_lints/src/types.rs
@@ -786,7 +786,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for UnitArg {
                             "passing a unit value to a function",
                             "if you intended to pass a unit value, use a unit literal instead",
                             "()".to_string(),
-                            Applicability::MachineApplicable,
+                            Applicability::MaybeIncorrect,
                         );
                     }
                 }