diff options
| author | Philipp Krones <hello@philkrones.com> | 2023-07-17 10:22:49 +0200 |
|---|---|---|
| committer | Philipp Krones <hello@philkrones.com> | 2023-07-17 10:22:49 +0200 |
| commit | 8ca13e83389f537ba389ce5fbd288b750bbdf7d4 (patch) | |
| tree | 7cad50c9f9d600a4ae814489136040e0494de492 | |
| parent | c2490bdc44aaa1feda8a21c616820ed434419ef5 (diff) | |
| download | rust-8ca13e83389f537ba389ce5fbd288b750bbdf7d4.tar.gz rust-8ca13e83389f537ba389ce5fbd288b750bbdf7d4.zip | |
Another fix for incorrect_impls
| -rw-r--r-- | src/tools/clippy/clippy_lints/src/incorrect_impls.rs | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/src/tools/clippy/clippy_lints/src/incorrect_impls.rs b/src/tools/clippy/clippy_lints/src/incorrect_impls.rs index c5da6039ac3..e6c42ebb832 100644 --- a/src/tools/clippy/clippy_lints/src/incorrect_impls.rs +++ b/src/tools/clippy/clippy_lints/src/incorrect_impls.rs @@ -4,7 +4,6 @@ use clippy_utils::{get_parent_node, is_res_lang_ctor, last_path_segment, path_re use rustc_errors::Applicability; use rustc_hir::def::Res; use rustc_hir::{Expr, ExprKind, ImplItem, ImplItemKind, ItemKind, LangItem, Node, UnOp}; -use rustc_hir_analysis::hir_ty_to_ty; use rustc_lint::{LateContext, LateLintPass}; use rustc_middle::ty::EarlyBinder; use rustc_session::{declare_lint_pass, declare_tool_lint}; @@ -121,7 +120,7 @@ impl LateLintPass<'_> for IncorrectImpls { if cx.tcx.is_automatically_derived(item.owner_id.to_def_id()) { return; } - let ItemKind::Impl(imp) = item.kind else { + let ItemKind::Impl(_) = item.kind else { return; }; let ImplItemKind::Fn(_, impl_item_id) = cx.tcx.hir().impl_item(impl_item.impl_item_id()).kind else { @@ -186,9 +185,9 @@ impl LateLintPass<'_> for IncorrectImpls { .get(&sym::Ord) && implements_trait( cx, - hir_ty_to_ty(cx.tcx, imp.self_ty), + trait_impl.self_ty(), *ord_def_id, - trait_impl.args, + &[], ) { if block.stmts.is_empty() |
