about summary refs log tree commit diff
diff options
context:
space:
mode:
authorAnatol Ulrich <anatol.ulrich@ferrous-systems.com>2021-10-27 15:40:00 +0200
committerAnatol Ulrich <anatol.ulrich@ferrous-systems.com>2021-10-27 15:40:30 +0200
commit8d3ac328ee3f60c7e06de4907a29b1aca62b35b4 (patch)
tree61b478ddbb3986c3ec6600f822705b4e1d4f972c
parentf244ed6a1a99d54eac8e703df252750eac5ef954 (diff)
downloadrust-8d3ac328ee3f60c7e06de4907a29b1aca62b35b4.tar.gz
rust-8d3ac328ee3f60c7e06de4907a29b1aca62b35b4.zip
remove resolved TODO questions
-rw-r--r--crates/ide/src/rename.rs1
-rw-r--r--crates/ide_db/src/source_change.rs2
2 files changed, 1 insertions, 2 deletions
diff --git a/crates/ide/src/rename.rs b/crates/ide/src/rename.rs
index bb23699cad4..59ba2b867ac 100644
--- a/crates/ide/src/rename.rs
+++ b/crates/ide/src/rename.rs
@@ -168,7 +168,6 @@ fn find_definitions(
     let v: RenameResult<Vec<(ast::NameLike, Definition)>> = symbols.collect();
     match v {
         // remove duplicates
-        // TODO is "unique by `Definition`" correct?
         Ok(v) => {
             if v.is_empty() {
                 Err(format_err!("No references found at position"))
diff --git a/crates/ide_db/src/source_change.rs b/crates/ide_db/src/source_change.rs
index c80da1d2f79..aa910eb3254 100644
--- a/crates/ide_db/src/source_change.rs
+++ b/crates/ide_db/src/source_change.rs
@@ -58,7 +58,7 @@ impl SourceChange {
     pub fn merge(mut self, other: SourceChange) -> SourceChange {
         self.extend(other.source_file_edits);
         self.extend(other.file_system_edits);
-        self.is_snippet |= other.is_snippet; // TODO correct?
+        self.is_snippet |= other.is_snippet;
         self
     }
 }