about summary refs log tree commit diff
diff options
context:
space:
mode:
authorMatthias Krüger <matthias.krueger@famsik.de>2022-11-25 18:35:39 +0100
committerGitHub <noreply@github.com>2022-11-25 18:35:39 +0100
commit8f3f4980b4c9cf7b062b2c7638070e256381114f (patch)
tree1404d367da3f6312e260c2b29473f5760630389d
parent9c7dc3e30b6a7c04190ceb96fb9a3f6e9bd1848a (diff)
parent2c5d3705ecb7ff07f5f47e736489d3abf3b64aa7 (diff)
downloadrust-8f3f4980b4c9cf7b062b2c7638070e256381114f.tar.gz
rust-8f3f4980b4c9cf7b062b2c7638070e256381114f.zip
Rollup merge of #104760 - nnethercote:rm-LegacyDerive, r=petrochenkov
Clarify `SyntaxExtensionKind::LegacyDerive`.

It's always treated the same as `SyntaxExtensionKind::Derive`.
-rw-r--r--compiler/rustc_expand/src/base.rs7
1 files changed, 6 insertions, 1 deletions
diff --git a/compiler/rustc_expand/src/base.rs b/compiler/rustc_expand/src/base.rs
index bdcd5334949..8955abebf1e 100644
--- a/compiler/rustc_expand/src/base.rs
+++ b/compiler/rustc_expand/src/base.rs
@@ -676,8 +676,13 @@ pub enum SyntaxExtensionKind {
 
     /// A token-based derive macro.
     Derive(
-        /// An expander with signature TokenStream -> TokenStream (not yet).
+        /// An expander with signature TokenStream -> TokenStream.
         /// The produced TokenSteam is appended to the input TokenSteam.
+        ///
+        /// FIXME: The text above describes how this should work. Currently it
+        /// is handled identically to `LegacyDerive`. It should be migrated to
+        /// a token-based representation like `Bang` and `Attr`, instead of
+        /// using `MultiItemModifier`.
         Box<dyn MultiItemModifier + sync::Sync + sync::Send>,
     ),