about summary refs log tree commit diff
diff options
context:
space:
mode:
authorbors[bot] <26634292+bors[bot]@users.noreply.github.com>2022-03-25 15:11:56 +0000
committerGitHub <noreply@github.com>2022-03-25 15:11:56 +0000
commit903d3bc4f7723b0e992a11d6ea9a5998e3ad1597 (patch)
tree0743f5ce2cbe17d56260cdb3c28c50c7907d6077
parentd64f455e884723f7d6e977ed785b7ac160a4af75 (diff)
parent44a99d6e4901cff1d8af178d69763a74926d0309 (diff)
downloadrust-903d3bc4f7723b0e992a11d6ea9a5998e3ad1597.tar.gz
rust-903d3bc4f7723b0e992a11d6ea9a5998e3ad1597.zip
Merge #11809
11809: feat: disable experimental diagnostics by default r=jonas-schievink a=jonas-schievink

Now that we diagnose type mismatches, we have another diagnostic that can potentially produce false positives, so let's disable experimental diagnostics by default.

Co-authored-by: Jonas Schievink <jonas.schievink@ferrous-systems.com>
-rw-r--r--crates/rust-analyzer/src/config.rs2
-rw-r--r--docs/user/generated_config.adoc2
-rw-r--r--editors/code/package.json2
3 files changed, 3 insertions, 3 deletions
diff --git a/crates/rust-analyzer/src/config.rs b/crates/rust-analyzer/src/config.rs
index f7df51e36a9..8fbf10072cd 100644
--- a/crates/rust-analyzer/src/config.rs
+++ b/crates/rust-analyzer/src/config.rs
@@ -176,7 +176,7 @@ config_data! {
         diagnostics_enable: bool                = "true",
         /// Whether to show experimental rust-analyzer diagnostics that might
         /// have more false positives than usual.
-        diagnostics_enableExperimental: bool    = "true",
+        diagnostics_enableExperimental: bool    = "false",
         /// List of rust-analyzer diagnostics to disable.
         diagnostics_disabled: FxHashSet<String> = "[]",
         /// Map of prefixes to be substituted when parsing diagnostic file paths.
diff --git a/docs/user/generated_config.adoc b/docs/user/generated_config.adoc
index bf8d482432e..1617ac5a7f8 100644
--- a/docs/user/generated_config.adoc
+++ b/docs/user/generated_config.adoc
@@ -223,7 +223,7 @@ Enables completions of private items and fields that are defined in the current
 --
 Whether to show native rust-analyzer diagnostics.
 --
-[[rust-analyzer.diagnostics.enableExperimental]]rust-analyzer.diagnostics.enableExperimental (default: `true`)::
+[[rust-analyzer.diagnostics.enableExperimental]]rust-analyzer.diagnostics.enableExperimental (default: `false`)::
 +
 --
 Whether to show experimental rust-analyzer diagnostics that might
diff --git a/editors/code/package.json b/editors/code/package.json
index bf242d68959..c55ef6f0f7c 100644
--- a/editors/code/package.json
+++ b/editors/code/package.json
@@ -645,7 +645,7 @@
                 },
                 "rust-analyzer.diagnostics.enableExperimental": {
                     "markdownDescription": "Whether to show experimental rust-analyzer diagnostics that might\nhave more false positives than usual.",
-                    "default": true,
+                    "default": false,
                     "type": "boolean"
                 },
                 "rust-analyzer.diagnostics.disabled": {