about summary refs log tree commit diff
diff options
context:
space:
mode:
authorhkalbasi <hamidrezakalbasi@protonmail.com>2022-12-07 02:29:50 +0330
committerhkalbasi <hamidrezakalbasi@protonmail.com>2022-12-07 02:29:50 +0330
commit948a8f030b51543aedf72188cf8d3ab03d5a3025 (patch)
tree81aede7338dc4ba2d084ca9d12f72c9729dac453
parent05906da0ec54fa218b4f395086e21af01ecec40a (diff)
downloadrust-948a8f030b51543aedf72188cf8d3ab03d5a3025.tar.gz
rust-948a8f030b51543aedf72188cf8d3ab03d5a3025.zip
Add a fixme comment in current_target_data_layout
-rw-r--r--crates/hir-ty/src/layout/target.rs2
1 files changed, 2 insertions, 0 deletions
diff --git a/crates/hir-ty/src/layout/target.rs b/crates/hir-ty/src/layout/target.rs
index 48b1a68d51b..b76274bb854 100644
--- a/crates/hir-ty/src/layout/target.rs
+++ b/crates/hir-ty/src/layout/target.rs
@@ -24,6 +24,8 @@ pub fn current_target_data_layout_query(db: &dyn HirDatabase) -> Arc<TargetDataL
             },
             _ => 8,
         });
+    // FIXME: These values are incorrect for many architectures, at least for aarch64 and riscv64,
+    // use `rustc +nightly -Z unstable-options --print target-spec-json` or something similar instead.
     Arc::new(TargetDataLayout {
         endian,
         i1_align: AbiAndPrefAlign::new(Align::from_bytes(1).unwrap()),