about summary refs log tree commit diff
diff options
context:
space:
mode:
authorantoyo <antoyo@users.noreply.github.com>2025-06-20 14:37:22 -0400
committerGitHub <noreply@github.com>2025-06-20 14:37:22 -0400
commit962a08ff4a3ea6f9b616bc821e8eaeb3d27a57a4 (patch)
tree26eb71538bac7c6696f4d6d9b24377e4559e0aeb
parent395bca167118b4d91951b360310828d5730280d1 (diff)
parentb2b117ee281c817e1edbe34429a5a77faa2f3ece (diff)
downloadrust-962a08ff4a3ea6f9b616bc821e8eaeb3d27a57a4.tar.gz
rust-962a08ff4a3ea6f9b616bc821e8eaeb3d27a57a4.zip
Merge pull request #716 from FractalFir/abi-cafe
Fixed some clippy warnings.
-rw-r--r--build_system/src/abi_test.rs7
1 files changed, 5 insertions, 2 deletions
diff --git a/build_system/src/abi_test.rs b/build_system/src/abi_test.rs
index 421bc387ce8..3c1531be27a 100644
--- a/build_system/src/abi_test.rs
+++ b/build_system/src/abi_test.rs
@@ -13,13 +13,16 @@ fn show_usage() {
 
 pub fn run() -> Result<(), String> {
     let mut args = std::env::args().skip(2);
+    // FractalFir: In the future, I'd like to add some more subcommands / options.
+    // So, this loop ought to stay for that purpose. It should also stay as a while loop(to parse args)
+    #[allow(clippy::never_loop, clippy::while_let_on_iterator)]
     while let Some(arg) = args.next() {
         match arg.as_str() {
             "--help" => {
                 show_usage();
                 return Ok(());
             }
-            _ => return Err(format!("Unknown option {}", arg)),
+            _ => return Err(format!("Unknown option {arg:?}")),
         }
     }
     // Ensure that we have a cloned version of abi-cafe on hand.
@@ -56,7 +59,7 @@ pub fn run() -> Result<(), String> {
         &"c_calls_cg_gcc",
     ];
     // Run ABI cafe.
-    run_command_with_output(cmd, Some(&Path::new("clones/abi-cafe")))?;
+    run_command_with_output(cmd, Some(Path::new("clones/abi-cafe")))?;
 
     Ok(())
 }