diff options
| author | Andrea Nall <anall@andreanall.com> | 2022-07-07 19:30:37 +0000 |
|---|---|---|
| committer | Andrea Nall <anall@andreanall.com> | 2022-07-07 19:30:37 +0000 |
| commit | 98b84195a217f53659d8f88ff9427ac7e463ccfb (patch) | |
| tree | 1670cf90bc0d72aa1257fe4334c42f12bc52a574 | |
| parent | 3e51277fe638dc0c8ceb6d1d3acc5aa247277c29 (diff) | |
| download | rust-98b84195a217f53659d8f88ff9427ac7e463ccfb.tar.gz rust-98b84195a217f53659d8f88ff9427ac7e463ccfb.zip | |
Add test for and fix rust-lang/rust-clippy#9131
This lint seems to have been broken by #98446
| -rw-r--r-- | src/tools/clippy/clippy_lints/src/misc.rs | 2 | ||||
| -rw-r--r-- | src/tools/clippy/tests/ui/used_underscore_binding.rs | 6 | ||||
| -rw-r--r-- | src/tools/clippy/tests/ui/used_underscore_binding.stderr | 2 |
3 files changed, 8 insertions, 2 deletions
diff --git a/src/tools/clippy/clippy_lints/src/misc.rs b/src/tools/clippy/clippy_lints/src/misc.rs index df2430ced6b..be7df08d89f 100644 --- a/src/tools/clippy/clippy_lints/src/misc.rs +++ b/src/tools/clippy/clippy_lints/src/misc.rs @@ -301,7 +301,7 @@ fn in_attributes_expansion(expr: &Expr<'_>) -> bool { use rustc_span::hygiene::MacroKind; if expr.span.from_expansion() { let data = expr.span.ctxt().outer_expn_data(); - matches!(data.kind, ExpnKind::Macro(MacroKind::Attr, _)) + matches!(data.kind, ExpnKind::Macro(MacroKind::Attr|MacroKind::Derive, _)) } else { false } diff --git a/src/tools/clippy/tests/ui/used_underscore_binding.rs b/src/tools/clippy/tests/ui/used_underscore_binding.rs index 21d66d5df79..d20977d55d2 100644 --- a/src/tools/clippy/tests/ui/used_underscore_binding.rs +++ b/src/tools/clippy/tests/ui/used_underscore_binding.rs @@ -44,6 +44,12 @@ fn in_struct_field() { s._underscore_field += 1; } +/// Tests that we do not lint if the struct field is used in code created with derive. +#[derive(Clone, Debug)] +pub struct UnderscoreInStruct { + _foo: u32, +} + /// Tests that we do not lint if the underscore is not a prefix fn non_prefix_underscore(some_foo: u32) -> u32 { some_foo + 1 diff --git a/src/tools/clippy/tests/ui/used_underscore_binding.stderr b/src/tools/clippy/tests/ui/used_underscore_binding.stderr index 790b849210c..61a9161d212 100644 --- a/src/tools/clippy/tests/ui/used_underscore_binding.stderr +++ b/src/tools/clippy/tests/ui/used_underscore_binding.stderr @@ -31,7 +31,7 @@ LL | s._underscore_field += 1; | ^^^^^^^^^^^^^^^^^^^ error: used binding `_i` which is prefixed with an underscore. A leading underscore signals that a binding will not be used - --> $DIR/used_underscore_binding.rs:99:16 + --> $DIR/used_underscore_binding.rs:105:16 | LL | uses_i(_i); | ^^ |