about summary refs log tree commit diff
diff options
context:
space:
mode:
authorDániel Buga <bugadani@gmail.com>2021-01-22 08:22:15 +0100
committerDániel Buga <bugadani@gmail.com>2021-01-22 08:22:15 +0100
commit9988821a04073360c27bd95b9535a8dceca67d9c (patch)
tree2757c7922e24ff8baf95481b12a50ba3da7a8d74
parent58a90de9adfac7cc26fe178b3f736153b756a515 (diff)
downloadrust-9988821a04073360c27bd95b9535a8dceca67d9c.tar.gz
rust-9988821a04073360c27bd95b9535a8dceca67d9c.zip
Move missing_item check inside condition
-rw-r--r--compiler/rustc_typeck/src/check/check.rs10
1 files changed, 5 insertions, 5 deletions
diff --git a/compiler/rustc_typeck/src/check/check.rs b/compiler/rustc_typeck/src/check/check.rs
index e89a063598a..ace2ccb2fce 100644
--- a/compiler/rustc_typeck/src/check/check.rs
+++ b/compiler/rustc_typeck/src/check/check.rs
@@ -1043,9 +1043,9 @@ pub(super) fn check_impl_items_against_trait<'tcx>(
         }
     }
 
-    // Check for missing items from trait
-    let mut missing_items = Vec::new();
     if let Ok(ancestors) = trait_def.ancestors(tcx, impl_id.to_def_id()) {
+        // Check for missing items from trait
+        let mut missing_items = Vec::new();
         for trait_item in tcx.associated_items(impl_trait_ref.def_id).in_definition_order() {
             let is_implemented = ancestors
                 .leaf_def(tcx, trait_item.ident, trait_item.kind)
@@ -1058,10 +1058,10 @@ pub(super) fn check_impl_items_against_trait<'tcx>(
                 }
             }
         }
-    }
 
-    if !missing_items.is_empty() {
-        missing_items_err(tcx, impl_span, &missing_items, full_impl_span);
+        if !missing_items.is_empty() {
+            missing_items_err(tcx, impl_span, &missing_items, full_impl_span);
+        }
     }
 }