about summary refs log tree commit diff
diff options
context:
space:
mode:
authorJakub Beránek <jakub.beranek@vsb.cz>2024-06-12 20:52:40 +0200
committerJakub Beránek <jakub.beranek@vsb.cz>2024-06-12 20:52:40 +0200
commit9bba39c287a021c97a5b36fcced8dd34a32a3b87 (patch)
treeab0610388306e7ee2e49efc7006aab65daf21219
parent1d43fbbc7348f2bd9260d8532bffa02f5bd2c9ac (diff)
downloadrust-9bba39c287a021c97a5b36fcced8dd34a32a3b87.tar.gz
rust-9bba39c287a021c97a5b36fcced8dd34a32a3b87.zip
Improve error message if dependency installation in tidy fails
-rw-r--r--src/tools/tidy/src/ext_tool_checks.rs9
1 files changed, 7 insertions, 2 deletions
diff --git a/src/tools/tidy/src/ext_tool_checks.rs b/src/tools/tidy/src/ext_tool_checks.rs
index 2c97a39f100..b54fa5c6b2c 100644
--- a/src/tools/tidy/src/ext_tool_checks.rs
+++ b/src/tools/tidy/src/ext_tool_checks.rs
@@ -274,13 +274,18 @@ fn create_venv_at_path(path: &Path) -> Result<(), Error> {
     if out.status.success() {
         return Ok(());
     }
-    let err = if String::from_utf8_lossy(&out.stderr).contains("No module named virtualenv") {
+
+    let stderr = String::from_utf8_lossy(&out.stderr);
+    let err = if stderr.contains("No module named virtualenv") {
         Error::Generic(format!(
             "virtualenv not found: you may need to install it \
                                (`python3 -m pip install venv`)"
         ))
     } else {
-        Error::Generic(format!("failed to create venv at '{}' using {sys_py}", path.display()))
+        Error::Generic(format!(
+            "failed to create venv at '{}' using {sys_py}: {stderr}",
+            path.display()
+        ))
     };
     Err(err)
 }