about summary refs log tree commit diff
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2016-04-30 04:55:28 -0700
committerbors <bors@rust-lang.org>2016-04-30 04:55:28 -0700
commit9e17622449ae4280463f00dfc4b1a5f7e25f9ad0 (patch)
treecb50dc268bef828e734b027ff561cf8b2cdb0e04
parentb0aefff71499ac8e5f65c4a241b279e687c44c36 (diff)
parent6bc93183183d070bf355bbd5714209fd00631e1e (diff)
downloadrust-9e17622449ae4280463f00dfc4b1a5f7e25f9ad0.tar.gz
rust-9e17622449ae4280463f00dfc4b1a5f7e25f9ad0.zip
Auto merge of #33279 - brson:insert-diatribe-against-github-here, r=alexcrichton
configure: Add a sanity check for tarballs without submodules

Because GitHub publishes broken tarballs on our behalf that we can't
disable, this adds a check that src/liblibc exists, and then
complains if not.

Tested.
-rwxr-xr-xconfigure13
1 files changed, 13 insertions, 0 deletions
diff --git a/configure b/configure
index 5273e4c03e7..e96ed327df3 100755
--- a/configure
+++ b/configure
@@ -1453,6 +1453,19 @@ then
     cd ${CFG_BUILD_DIR}
 fi
 
+# Do a sanity check that the submodule source exists. Because GitHub
+# automatically publishes broken tarballs that can't be disabled, and
+# people download them and try to use them.
+if [ ! -e "${CFG_SRC_DIR}/src/liblibc" ]; then
+    err "some submodules are missing. Is this a broken tarball?
+
+If you downloaded this tarball from the GitHub release pages at
+https://github.com/rust-lang/rust/releases,
+then please delete it and instead download the source from
+https://www.rust-lang.org/downloads.html"
+
+fi
+
 # Configure llvm, only if necessary
 step_msg "looking at LLVM"
 CFG_LLVM_SRC_DIR=${CFG_SRC_DIR}src/llvm/