about summary refs log tree commit diff
diff options
context:
space:
mode:
authorWilco Kusee <wilcokusee@gmail.com>2019-01-13 13:10:25 +0100
committerWilco Kusee <wilcokusee@gmail.com>2019-01-13 13:10:25 +0100
commit9ff821a7e822cbc81d4370202bd1af08c2d18c63 (patch)
tree776f95956557f8b812bd5b27e85d627cf8bfbc57
parentfb90fcb61062497a18f31799965750ddffde0443 (diff)
downloadrust-9ff821a7e822cbc81d4370202bd1af08c2d18c63.tar.gz
rust-9ff821a7e822cbc81d4370202bd1af08c2d18c63.zip
Add run-rustfix to map_clone test
-rw-r--r--tests/ui/map_clone.fixed11
-rw-r--r--tests/ui/map_clone.rs2
-rw-r--r--tests/ui/map_clone.stderr6
3 files changed, 16 insertions, 3 deletions
diff --git a/tests/ui/map_clone.fixed b/tests/ui/map_clone.fixed
new file mode 100644
index 00000000000..5c419488286
--- /dev/null
+++ b/tests/ui/map_clone.fixed
@@ -0,0 +1,11 @@
+// run-rustfix
+#![warn(clippy::all, clippy::pedantic)]
+#![allow(clippy::iter_cloned_collect)]
+#![allow(clippy::missing_docs_in_private_items)]
+
+fn main() {
+    let _: Vec<i8> = vec![5_i8; 6].iter().cloned().collect();
+    let _: Vec<String> = vec![String::new()].iter().cloned().collect();
+    let _: Vec<u32> = vec![42, 43].iter().cloned().collect();
+    let _: Option<u64> = Some(Box::new(16)).map(|b| *b);
+}
diff --git a/tests/ui/map_clone.rs b/tests/ui/map_clone.rs
index a70cb2f6725..96a615ae54c 100644
--- a/tests/ui/map_clone.rs
+++ b/tests/ui/map_clone.rs
@@ -1,4 +1,6 @@
+// run-rustfix
 #![warn(clippy::all, clippy::pedantic)]
+#![allow(clippy::iter_cloned_collect)]
 #![allow(clippy::missing_docs_in_private_items)]
 
 fn main() {
diff --git a/tests/ui/map_clone.stderr b/tests/ui/map_clone.stderr
index 56b1f67bac9..63889055aa0 100644
--- a/tests/ui/map_clone.stderr
+++ b/tests/ui/map_clone.stderr
@@ -1,5 +1,5 @@
 error: You are using an explicit closure for cloning elements
-  --> $DIR/map_clone.rs:5:22
+  --> $DIR/map_clone.rs:7:22
    |
 LL |     let _: Vec<i8> = vec![5_i8; 6].iter().map(|x| *x).collect();
    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `vec![5_i8; 6].iter().cloned()`
@@ -7,13 +7,13 @@ LL |     let _: Vec<i8> = vec![5_i8; 6].iter().map(|x| *x).collect();
    = note: `-D clippy::map-clone` implied by `-D warnings`
 
 error: You are using an explicit closure for cloning elements
-  --> $DIR/map_clone.rs:6:26
+  --> $DIR/map_clone.rs:8:26
    |
 LL |     let _: Vec<String> = vec![String::new()].iter().map(|x| x.clone()).collect();
    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `vec![String::new()].iter().cloned()`
 
 error: You are using an explicit closure for cloning elements
-  --> $DIR/map_clone.rs:7:23
+  --> $DIR/map_clone.rs:9:23
    |
 LL |     let _: Vec<u32> = vec![42, 43].iter().map(|&x| x).collect();
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `vec![42, 43].iter().cloned()`