diff options
| author | Niki4tap <rombiklol2@gmail.com> | 2022-12-23 01:14:07 +0300 |
|---|---|---|
| committer | Niki4tap <rombiklol2@gmail.com> | 2022-12-23 01:14:07 +0300 |
| commit | 9ff868c4ae90f2b94d086cf8cf6302118c29f2ee (patch) | |
| tree | ac9883470b80f8c188d10e4c1e143d48c7b52cd9 | |
| parent | a9358260717e55c367f16bc033990bac77cfb5a1 (diff) | |
| download | rust-9ff868c4ae90f2b94d086cf8cf6302118c29f2ee.tar.gz rust-9ff868c4ae90f2b94d086cf8cf6302118c29f2ee.zip | |
test test test
| -rw-r--r-- | tests/ui/needless_return.fixed | 10 | ||||
| -rw-r--r-- | tests/ui/needless_return.rs | 10 | ||||
| -rw-r--r-- | tests/ui/needless_return.stderr | 18 |
3 files changed, 37 insertions, 1 deletions
diff --git a/tests/ui/needless_return.fixed b/tests/ui/needless_return.fixed index d451be1f389..ab1c0e590bb 100644 --- a/tests/ui/needless_return.fixed +++ b/tests/ui/needless_return.fixed @@ -277,4 +277,14 @@ fn issue9947() -> Result<(), String> { do yeet "hello"; } +// without anyhow, but triggers the same bug I believe +#[expect(clippy::useless_format)] +fn issue10051() -> Result<String, String> { + if true { + Ok(format!("ok!")) + } else { + Err(format!("err!")) + } +} + fn main() {} diff --git a/tests/ui/needless_return.rs b/tests/ui/needless_return.rs index e1a1bea2c0b..abed338bb9b 100644 --- a/tests/ui/needless_return.rs +++ b/tests/ui/needless_return.rs @@ -287,4 +287,14 @@ fn issue9947() -> Result<(), String> { do yeet "hello"; } +// without anyhow, but triggers the same bug I believe +#[expect(clippy::useless_format)] +fn issue10051() -> Result<String, String> { + if true { + return Ok(format!("ok!")); + } else { + return Err(format!("err!")); + } +} + fn main() {} diff --git a/tests/ui/needless_return.stderr b/tests/ui/needless_return.stderr index ca2253e6586..52eabf6e137 100644 --- a/tests/ui/needless_return.stderr +++ b/tests/ui/needless_return.stderr @@ -386,5 +386,21 @@ LL | let _ = 42; return; | = help: remove `return` -error: aborting due to 46 previous errors +error: unneeded `return` statement + --> $DIR/needless_return.rs:294:9 + | +LL | return Ok(format!("ok!")); + | ^^^^^^^^^^^^^^^^^^^^^^^^^ + | + = help: remove `return` + +error: unneeded `return` statement + --> $DIR/needless_return.rs:296:9 + | +LL | return Err(format!("err!")); + | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ + | + = help: remove `return` + +error: aborting due to 48 previous errors |