diff options
| author | Alexandre Oliveira <rockytvbr@gmail.com> | 2016-08-14 16:30:50 -0300 |
|---|---|---|
| committer | Alexandre Oliveira <rockytvbr@gmail.com> | 2016-08-14 16:33:25 -0300 |
| commit | a026e2c727312fc47b111cc29e684adec7caf341 (patch) | |
| tree | 99ccf666b73dbdb73bd8cfd20948252010459d56 | |
| parent | 92ae4ceb6c6563b983a046f5f273cc13247eb4b1 (diff) | |
| download | rust-a026e2c727312fc47b111cc29e684adec7caf341.tar.gz rust-a026e2c727312fc47b111cc29e684adec7caf341.zip | |
Update error E0365 to new format
| -rw-r--r-- | src/librustc_resolve/resolve_imports.rs | 12 | ||||
| -rw-r--r-- | src/test/compile-fail/E0365.rs | 5 |
2 files changed, 10 insertions, 7 deletions
diff --git a/src/librustc_resolve/resolve_imports.rs b/src/librustc_resolve/resolve_imports.rs index 6986f99926e..67588912014 100644 --- a/src/librustc_resolve/resolve_imports.rs +++ b/src/librustc_resolve/resolve_imports.rs @@ -582,12 +582,12 @@ impl<'a, 'b:'a> ImportResolver<'a, 'b> { source); self.session.add_lint(PRIVATE_IN_PUBLIC, directive.id, directive.span, msg); } else { - let msg = format!("`{}` is private, and cannot be reexported", source); - let note_msg = - format!("consider declaring type or module `{}` with `pub`", source); - struct_span_err!(self.session, directive.span, E0365, "{}", &msg) - .span_note(directive.span, ¬e_msg) - .emit(); + let mut err = struct_span_err!(self.session, directive.span, E0365, + "`{}` is private, and cannot be reexported", + source); + err.span_label(directive.span, &format!("reexport of private `{}`", source)); + err.note(&format!("consider declaring type or module `{}` with `pub`", source)); + err.emit(); } } diff --git a/src/test/compile-fail/E0365.rs b/src/test/compile-fail/E0365.rs index 7b0fbcc6203..ea5fd6ed477 100644 --- a/src/test/compile-fail/E0365.rs +++ b/src/test/compile-fail/E0365.rs @@ -12,6 +12,9 @@ mod foo { pub const X: u32 = 1; } -pub use foo as foo2; //~ ERROR E0365 +pub use foo as foo2; +//~^ ERROR `foo` is private, and cannot be reexported [E0365] +//~| NOTE reexport of private `foo` +//~| NOTE consider declaring type or module `foo` with `pub` fn main() {} |
