about summary refs log tree commit diff
diff options
context:
space:
mode:
authorTyler Mandry <tmandry@gmail.com>2020-08-11 12:28:39 -0700
committerGitHub <noreply@github.com>2020-08-11 12:28:39 -0700
commita028c3176a9b8a5fd282ae4cae3cce4c8371d9fa (patch)
tree88e654aa80b691288bebc2c50471342f56133032
parent06eb274bfcedeb69fc60068bdc2da14f57a442d1 (diff)
parent24177319ca8502bd957077671d21abbbb20df4f6 (diff)
downloadrust-a028c3176a9b8a5fd282ae4cae3cce4c8371d9fa.tar.gz
rust-a028c3176a9b8a5fd282ae4cae3cce4c8371d9fa.zip
Rollup merge of #75408 - mati865:update-ci-comment, r=pietroalbini
Update MinGW comments in ci.yml
-rw-r--r--src/ci/github-actions/ci.yml12
1 files changed, 7 insertions, 5 deletions
diff --git a/src/ci/github-actions/ci.yml b/src/ci/github-actions/ci.yml
index 0ff77de003d..165ecc79180 100644
--- a/src/ci/github-actions/ci.yml
+++ b/src/ci/github-actions/ci.yml
@@ -490,15 +490,17 @@ jobs:
 
           # 32/64-bit MinGW builds.
           #
-          # We are using MinGW with posix threads since LLVM does not compile with
-          # the win32 threads version due to missing support for C++'s std::thread.
+          # We are using MinGW with POSIX threads since LLVM requires
+          # C++'s std::thread which is disabled in libstdc++ with win32 threads.
+          # FIXME: Libc++ doesn't have this limitation so we can avoid 
+          # winpthreads if we switch to it.
           #
-          # Instead of relying on the MinGW version installed on appveryor we download
-          # and install one ourselves so we won't be surprised by changes to appveyor's
+          # Instead of relying on the MinGW version installed on CI we download
+          # and install one ourselves so we won't be surprised by changes to CI's
           # build image.
           #
           # Finally, note that the downloads below are all in the `rust-lang-ci` S3
-          # bucket, but they cleraly didn't originate there! The downloads originally
+          # bucket, but they clearly didn't originate there! The downloads originally
           # came from the mingw-w64 SourceForge download site. Unfortunately
           # SourceForge is notoriously flaky, so we mirror it on our own infrastructure.