about summary refs log tree commit diff
diff options
context:
space:
mode:
authorGuillaume Gomez <guillaume1.gomez@gmail.com>2024-04-17 00:00:25 +0200
committerGitHub <noreply@github.com>2024-04-17 00:00:25 +0200
commita0ca1184dae795e05e8c082e5b92ec0873da42f5 (patch)
tree948178c6d35965e8711056d97c5880f92ea87196
parentc7b009f38a340892a500e009c9d3ccd300e6d5af (diff)
parentf25668cff5930bc815f84b33861cf57fa5dd4200 (diff)
downloadrust-a0ca1184dae795e05e8c082e5b92ec0873da42f5.tar.gz
rust-a0ca1184dae795e05e8c082e5b92ec0873da42f5.zip
Rollup merge of #124036 - alexcrichton:wasm-use-default-visbility, r=jieyouxu
Remove `default_hidden_visibility: false` from wasm targets

To the best of my ability I believe that this is no longer necessary. I don't fully recall why this was first added but I believe it had to do with symbols all being exported by default and this was required to undo that. Regardless nowadays the default output of rustc seems suitable so it seems best to keep wasm in line with other targets.
-rw-r--r--compiler/rustc_target/src/spec/base/wasm.rs3
1 files changed, 0 insertions, 3 deletions
diff --git a/compiler/rustc_target/src/spec/base/wasm.rs b/compiler/rustc_target/src/spec/base/wasm.rs
index 4b4d2aca26e..f237391016e 100644
--- a/compiler/rustc_target/src/spec/base/wasm.rs
+++ b/compiler/rustc_target/src/spec/base/wasm.rs
@@ -80,9 +80,6 @@ pub fn options() -> TargetOptions {
         // threaded model which will legalize atomics to normal operations.
         singlethread: true,
 
-        // no dynamic linking, no need for default visibility!
-        default_hidden_visibility: true,
-
         // Symbol visibility takes care of this for the WebAssembly.
         // Additionally the only known linker, LLD, doesn't support the script
         // arguments just yet