about summary refs log tree commit diff
diff options
context:
space:
mode:
authorMazdak Farrokhzad <twingoow@gmail.com>2019-12-16 17:33:07 +0100
committerGitHub <noreply@github.com>2019-12-16 17:33:07 +0100
commita1580e72daee5fa9b7a61a74a20326b8c5741177 (patch)
tree6f22aebe44a23aa1b7059d12f28952ea46b441b0
parenta6f817f42926ab6d7487081209fbff674934b4a0 (diff)
parent2514cd555bdacedf3df7941c5a17d98cfa0e0cd4 (diff)
downloadrust-a1580e72daee5fa9b7a61a74a20326b8c5741177.tar.gz
rust-a1580e72daee5fa9b7a61a74a20326b8c5741177.zip
Rollup merge of #67308 - dtolnay:fast_rebind, r=alexcrichton
Delete flaky test net::tcp::tests::fast_rebind

This test is unreliable for at least 3 users on two platforms: see #57509 and #51006. It was added 5 years ago in #22015. Do we know whether this is testing something important that would indicate a bug in our implementation, or if it's fine to remove?

r? @sfackler @alexcrichton because this somewhat resembles #59018

Closes #57509. Closes #51006.
-rw-r--r--src/libstd/net/tcp.rs15
1 files changed, 0 insertions, 15 deletions
diff --git a/src/libstd/net/tcp.rs b/src/libstd/net/tcp.rs
index 5c022159970..c33f98bdd83 100644
--- a/src/libstd/net/tcp.rs
+++ b/src/libstd/net/tcp.rs
@@ -1313,21 +1313,6 @@ mod tests {
     }
 
     #[test]
-    fn fast_rebind() {
-        each_ip(&mut |addr| {
-            let acceptor = t!(TcpListener::bind(&addr));
-
-            let _t = thread::spawn(move || {
-                t!(TcpStream::connect(&addr));
-            });
-
-            t!(acceptor.accept());
-            drop(acceptor);
-            t!(TcpListener::bind(&addr));
-        });
-    }
-
-    #[test]
     fn tcp_clone_smoke() {
         each_ip(&mut |addr| {
             let acceptor = t!(TcpListener::bind(&addr));