about summary refs log tree commit diff
diff options
context:
space:
mode:
authorbjorn3 <bjorn3@users.noreply.github.com>2022-03-13 15:46:25 +0100
committerbjorn3 <bjorn3@users.noreply.github.com>2022-03-13 17:58:02 +0100
commita48fea6dda1890d2b2061dd680091d842c79ce0a (patch)
treec9c3f0ac04aeeacb70a01452c505dc396c16805d
parentfef517eae74336ef290c3982ab5543458b7b9b5a (diff)
downloadrust-a48fea6dda1890d2b2061dd680091d842c79ce0a.tar.gz
rust-a48fea6dda1890d2b2061dd680091d842c79ce0a.zip
Add and remove some fixmes
-rw-r--r--build_system/prepare.rs1
-rwxr-xr-xscripts/tests.sh1
-rw-r--r--src/debuginfo/line_info.rs1
3 files changed, 1 insertions, 2 deletions
diff --git a/build_system/prepare.rs b/build_system/prepare.rs
index 4a7df2cebbc..90b3390626d 100644
--- a/build_system/prepare.rs
+++ b/build_system/prepare.rs
@@ -14,6 +14,7 @@ pub(crate) fn prepare() {
     eprintln!("[INSTALL] hyperfine");
     Command::new("cargo").arg("install").arg("hyperfine").spawn().unwrap().wait().unwrap();
 
+    // FIXME download source archives where possible instead
     clone_repo(
         "rand",
         "https://github.com/rust-random/rand.git",
diff --git a/scripts/tests.sh b/scripts/tests.sh
index bdb3de0936d..fee1012c8f1 100755
--- a/scripts/tests.sh
+++ b/scripts/tests.sh
@@ -57,7 +57,6 @@ function base_sysroot_tests() {
     fi
 
     echo "[AOT] dst_field_align"
-    # FIXME Re-add -Zmir-opt-level=2 once rust-lang/rust#67529 is fixed.
     $MY_RUSTC example/dst-field-align.rs --crate-name dst_field_align --crate-type bin --target "$TARGET_TRIPLE"
     $RUN_WRAPPER ./target/out/dst_field_align || (echo $?; false)
 
diff --git a/src/debuginfo/line_info.rs b/src/debuginfo/line_info.rs
index c7e15f81e03..476d6a54e12 100644
--- a/src/debuginfo/line_info.rs
+++ b/src/debuginfo/line_info.rs
@@ -110,7 +110,6 @@ impl<'tcx> DebugContext<'tcx> {
 
         entry.set(gimli::DW_AT_decl_file, AttributeValue::FileIndex(Some(file_id)));
         entry.set(gimli::DW_AT_decl_line, AttributeValue::Udata(loc.line as u64));
-        // FIXME: probably omit this
         entry.set(gimli::DW_AT_decl_column, AttributeValue::Udata(loc.col.to_usize() as u64));
     }